Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker as preferred driver on macOS/Windows #8353

Closed
tstromberg opened this issue Jun 1, 2020 · 8 comments
Closed

Docker as preferred driver on macOS/Windows #8353

tstromberg opened this issue Jun 1, 2020 · 8 comments
Assignees
Labels
co/docker-driver Issues related to kubernetes in container kind/process Process oriented issues, like setting up CI priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@tstromberg
Copy link
Contributor

tstromberg commented Jun 1, 2020

At the moment, we default to:

  • Docker on Linux

  • Hyperkit on macOS

  • Hyper-V on Windows

  • On macOS, Docker is better at VPN handling.

  • On Windows, Docker is better at privilege handling.

This suggests that for most users, we could make the default Docker for all platforms, and fall-back to Hyperkit/Hyper-V if Docker is not available.

@tstromberg tstromberg added this to the v1.12.0-candidate milestone Jun 1, 2020
@tstromberg tstromberg changed the title Make Docker the preferred driver to help with driver fallback Make Docker the preferred driver (with driver fallback) Jun 1, 2020
@tstromberg tstromberg changed the title Make Docker the preferred driver (with driver fallback) Make Docker the preferred driver on macOS/Windows (with driver fallback) Jun 1, 2020
@tstromberg tstromberg changed the title Make Docker the preferred driver on macOS/Windows (with driver fallback) Docker as preferred driver on macOS/Windows Jun 1, 2020
@afbjorklund
Copy link
Collaborator

afbjorklund commented Jun 1, 2020

Is this related to #8135 ?

For the Linux default: it seems that some of the "none" users are struggling with "docker"

We have some suggestion where we encourage them to change, not always working out...

@tstromberg
Copy link
Contributor Author

@afbjorklund - not directly related, no. This is for the default case on macOS/Windows when one does not specify a --driver option.

@afbjorklund
Copy link
Collaborator

The semantic difference between preferred and default is not clear to me, they looked the same.

@afbjorklund afbjorklund added the co/docker-driver Issues related to kubernetes in container label Jun 1, 2020
@afbjorklund
Copy link
Collaborator

afbjorklund commented Jun 1, 2020

There were also some objections to this wording:
For non-root usage, try the newer 'docker' driver

Even though minikube itself does not require root,
docker does require root (group). So it's not really "non-root" ?

See #8257

@sharifelgamal sharifelgamal added kind/process Process oriented issues, like setting up CI priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 2, 2020
@afbjorklund
Copy link
Collaborator

Should we make the persistent volume handling a blocker for this ?
Currently they are not being persisted, but stored on tmpfs : #8151

It is the same on Linux (where it is already default driver), though.
Just getting more exposure, with more users from Mac and Win.

@tstromberg
Copy link
Contributor Author

tstromberg commented Jun 20, 2020 via email

@afbjorklund
Copy link
Collaborator

Well, at least it is consistent over the platforms now

@afbjorklund
Copy link
Collaborator

We moved the storage issue to 1.13, see: #8657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/docker-driver Issues related to kubernetes in container kind/process Process oriented issues, like setting up CI priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

5 participants