Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KIC CNI config to have parameterized pod subnet #7936

Closed
sharifelgamal opened this issue Apr 29, 2020 · 3 comments
Closed

Fix KIC CNI config to have parameterized pod subnet #7936

sharifelgamal opened this issue Apr 29, 2020 · 3 comments
Labels
area/networking networking issues co/multinode Issues related to multinode clusters kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@sharifelgamal
Copy link
Collaborator

Currently the pod subnet for kic's CNI config is hardcoded:

 - name: POD_SUBNET
          value: 10.244.0.0/16

which is the correct default to have, but we should be able to respect a subnet that a user passes in via the --extra-options=kubeadm.pod-network-cidr parameter.
@sharifelgamal sharifelgamal added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/networking networking issues co/multinode Issues related to multinode clusters labels Apr 29, 2020
@medyagh medyagh added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 29, 2020
@medyagh medyagh added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 9, 2020
@prasadkatti
Copy link
Contributor

This seems to have been fixed in #8545
Here : 9e95435#diff-38ffa3aa6db3a315c7abe51a11b3c6b3

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 12, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/networking networking issues co/multinode Issues related to multinode clusters kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@medyagh @prasadkatti @k8s-ci-robot @sharifelgamal @fejta-bot