Add --cni flag (replaces --enable-default-cni), fix --network-plugin handling #8545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XXL
k8s-ci-robot
added
ok-to-test
|
kvm2 Driver Times for Minikube (PR 8545): [65.50141211699999 59.201991816 63.051135050999996] Averages Time Per Log docker Driver Times for Minikube (PR 8545): [26.312457348000006 26.475253973999997 26.332362903] Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 8545): [66.76618305 60.24707035699999 64.63725781999999] Averages Time Per Log docker Driver Times for Minikube (PR 8545): [26.030247301000003 25.694407717999997 27.65185485] Averages Time Per Log |
Travis tests have failedHey @tstromberg, 1st Buildmake testTravisBuddy Request Identifier: 22015800-b70e-11ea-bb0d-6965ce86ea0c |
|
kvm2 Driver Times for Minikube (PR 8545): [64.895559485 63.704116961000004 61.730437257999995] Averages Time Per Log docker Driver Times for Minikube (PR 8545): [26.602782805 25.550593832000004 26.187859631000002] Averages Time Per Log |
medyagh
approved these changes
Jun 25, 2020
medyagh
previously requested changes
Jun 25, 2020
There was a problem hiding this comment.
after removing dns test from functional, please update this number to 26
here
https://github.com/medyagh/minikube/blob/b8229c3014e1a9a535f7ff8342d6b9b7317d7b76/.github/workflows/pr.yml#L542-L543
and here
https://github.com/medyagh/minikube/blob/b8229c3014e1a9a535f7ff8342d6b9b7317d7b76/.github/workflows/master.yml#L544
(that check was added to ensure when test times out and nothing fails, we be aware of low number of Passes that makes us feel we passsed with 0 failures but not enough of passed tests)
I'll follow this PR up with one which adds Calico support. |
medyagh
requested changes
Jun 25, 2020
There was a problem hiding this comment.
same line needs to be fixed in master github action too
https://github.com/medyagh/minikube/blob/b8229c3014e1a9a535f7ff8342d6b9b7317d7b76/.github/workflows/master.yml#L544
Travis tests have failedHey @tstromberg, 1st Buildmake testTravisBuddy Request Identifier: d500c430-b72d-11ea-90cf-99978df78ba0 |
Travis tests have failedHey @tstromberg, 1st Buildmake testTravisBuddy Request Identifier: 67ee23a0-b72e-11ea-90cf-99978df78ba0 |
priyawadhwa
approved these changes
Jun 25, 2020
|
kvm2 Driver Times for Minikube (PR 8545): [64.925448332 62.98235371199999 65.19704372700001] Averages Time Per Log docker Driver Times for Minikube (PR 8545): [26.599586724999998 28.513189787 25.879961539] Averages Time Per Log |
Travis tests have failedHey @tstromberg, 1st Buildmake testTravisBuddy Request Identifier: 07951f90-b733-11ea-90cf-99978df78ba0 |
medyagh
approved these changes
Jun 25, 2020
Travis tests have failedHey @tstromberg, 1st Buildmake testTravisBuddy Request Identifier: f2272c10-b733-11ea-90cf-99978df78ba0 |
|
kvm2 Driver Times for Minikube (PR 8545): [59.77736803500001 61.852764822 64.81277180800002] Averages Time Per Log docker Driver Times for Minikube (PR 8545): [26.599576327999994 25.356229325 25.077881675999997] Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 8545): [63.272530231 62.54277446900001 61.439905833] Averages Time Per Log docker Driver Times for Minikube (PR 8545): [26.755699149 27.782569428 26.652289635000002] Averages Time Per Log |
|
I'm going to merge this and follow-it up with an improvement for CRIO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to specify different CNI plug-ins to use. As a side-effect, this also fixes
--network-plugin=kubenetFixes multi-node: unable to choose CNI (always applies kindnet) #8222
Does not fix CoreDNS fails on minions on multi-node clusters. Can't resolve external DNS from non-master pods. #8055 (kubelet configuration for CNI child nodes still needs work)
Unblocks Pod unable to reach itself through a service (unless --cni=true is set) #1568 and evaluate if can supply CNI by default for multinode and others #8354