Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add number of nodes for cluster in minikube profile list #6780

Closed
sharifelgamal opened this issue Feb 24, 2020 · 2 comments · Fixed by #9702
Closed

Add number of nodes for cluster in minikube profile list #6780

sharifelgamal opened this issue Feb 24, 2020 · 2 comments · Fixed by #9702
Labels
co/multinode Issues related to multinode clusters kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@sharifelgamal
Copy link
Collaborator

sharifelgamal commented Feb 24, 2020 •
edited
Loading

Currently if you have two clusters running and one of them has two nodes, minikube profile list looks like:

|----------|-----------|---------|------------|------|---------|---------|
| Profile  | VM Driver | Runtime |     IP     | Port | Version | Status  |
|----------|-----------|---------|------------|------|---------|---------|
| minikube | docker    | docker  | 172.17.0.2 | 8443 | v1.19.0 | Running |
| p1       | docker    | docker  | 172.17.0.4 | 8443 | v1.19.2 | Running |
|----------|-----------|---------|------------|------|---------|---------|
❗  Found 1 invalid profile(s) ! 
	 p1-m02
💡  You can delete them using the following command(s): 
	 $ minikube delete -p p1-m02

We'd like it to look like:

|----------|-----------|---------|------------|------|---------|---------|---------|
| Profile  | VM Driver | Runtime |     IP     | Port | Version | Status  | Nodes   |
|----------|-----------|---------|------------|------|---------|---------|---------|
| minikube | docker    | docker  | 172.17.0.2 | 8443 | v1.19.0 | Running | 1       |
| p1       | docker    | docker  | 172.17.0.4 | 8443 | v1.19.2 | Running | 2       |
|----------|-----------|---------|------------|------|---------|---------|---------|

So, we want to not have the spurious error at the end of the table, and to add the Nodes column with the number of nodes the cluster has.
@sharifelgamal sharifelgamal added the co/multinode Issues related to multinode clusters label Feb 24, 2020
@sharifelgamal sharifelgamal self-assigned this Feb 24, 2020
@priyawadhwa priyawadhwa added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 25, 2020
@tstromberg tstromberg added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 26, 2020
@medyagh
Copy link
Member

medyagh commented Apr 5, 2020

@sharifelgamal
how about to break this to smaller issues and have exampe errors and updates separately?

@govargo
Copy link
Contributor

govargo commented Apr 7, 2020 •
edited
Loading

I found this issue after I opend another issues(Sorry).

#7452 (and PR #7476)
#7475
(Added)
#7515 (and PR #7516)
#7517

I'll send PRs to fix above. Let me know if you don't need my PR.

@sharifelgamal sharifelgamal mentioned this issue Apr 9, 2020
Open
13 tasks
@sharifelgamal sharifelgamal added this to the v1.11.0 milestone Apr 21, 2020
@sharifelgamal sharifelgamal changed the title Fix status, ssh and profile commands for multinode Fix minikube profile command for multinode May 13, 2020
@medyagh medyagh changed the title Fix minikube profile command for multinode Fix minikube profile list command for multinode May 13, 2020
@priyawadhwa priyawadhwa modified the milestones: v1.11.0 May28, v.1.12.0 May 18, 2020
@medyagh medyagh removed this from the v.1.12.0-previous candidate (dumpster fire) milestone Jun 1, 2020
@sharifelgamal sharifelgamal added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 15, 2020
@sharifelgamal sharifelgamal changed the title Fix minikube profile list command for multinode Add number of nodes for cluster in minikube profile list Sep 22, 2020
@medyagh medyagh added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 22, 2020
@sharifelgamal sharifelgamal removed their assignment Sep 22, 2020
daehyeok added a commit to daehyeok/minikube that referenced this issue Nov 14, 2020
@daehyeok
Add number of nodes for cluster in minikube profile list
0169f09 
\kubernetes#6780 Add the Nodes column with the number of nodes the cluster has into
`minikube profile list` result.
daehyeok added a commit to daehyeok/minikube that referenced this issue Nov 14, 2020
@daehyeok
Add number of nodes for cluster in minikube profile list
f96729f 
fixes \kubernetes#6780
Add the Nodes column with the number of nodes the cluster has into
`minikube profile list` output.
@daehyeok daehyeok mentioned this issue Nov 14, 2020
Merged
daehyeok added a commit to daehyeok/minikube that referenced this issue Nov 22, 2020
@daehyeok
Add number of nodes for cluster in minikube profile list
97db8b5 
fixes \kubernetes#6780
Add the Nodes column with the number of nodes the cluster has into
`minikube profile list` output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
co/multinode Issues related to multinode clusters kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add number of nodes for cluster in minikube profile list daehyeok/minikube
5 participants
@tstromberg @medyagh @priyawadhwa @sharifelgamal @govargo