Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add architecture (and revision) to the packages #6281

Closed
afbjorklund opened this issue Jan 11, 2020 · 1 comment · Fixed by #6283
Closed

Add architecture (and revision) to the packages #6281

afbjorklund opened this issue Jan 11, 2020 · 1 comment · Fixed by #6283
Labels
area/build-release kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. packaging/apt Debian (apt) packaging issues packaging/rpm Red Hat/Fedora (rpm) packaging issues priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@afbjorklund
Copy link
Collaborator

afbjorklund commented Jan 11, 2020

Currently we truncate the filenames, to make it "easier" for users:

We should stop doing this, and use the real filenames instead.

  • minikube_1.6.2-0_amd64.deb
  • minikube-1.6.2-0.x86_64.rpm

This will make things less weird, when we support additional architectures...

  • minikube_1.6.2-0_arm64.deb
  • minikube-1.6.2-0.aarch64.rpm

For the raw minikube binary, we already include "-linux-amd64" in the filename.


The release is kept as 0, in case any distributions start packaging minikube...

And we still need to provide a real repository (apt, yum) for the vendor packages.

It's not like anyone wants to look after versions and architectures, but instead do:

  • sudo apt install minikube

  • sudo yum install minikube

@afbjorklund afbjorklund added area/build-release packaging/apt Debian (apt) packaging issues packaging/rpm Red Hat/Fedora (rpm) packaging issues labels Jan 11, 2020
@afbjorklund afbjorklund changed the title Add architecture (and release) to the packages Add architecture (and revision) to the packages Jan 11, 2020
@afbjorklund
Copy link
Collaborator Author

The same goes for the docker-machine-driver-kvm2 packages.

@medyagh medyagh added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jan 22, 2020
@tstromberg tstromberg added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-release kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. packaging/apt Debian (apt) packaging issues packaging/rpm Red Hat/Fedora (rpm) packaging issues priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants