Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document upgrading a cluster #6122

Closed
robrich opened this issue Dec 19, 2019 · 6 comments
Closed

Document upgrading a cluster #6122

robrich opened this issue Dec 19, 2019 · 6 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@robrich
Copy link
Contributor

robrich commented Dec 19, 2019

Now that #5798 is merged, and minikube start doesn't auto-upgrade, how do I upgrade my cluster? Will minikube start --kubernetes-version ... upgrade it or dump the VM and start over? (and consume all the bandwidth as I download base images again.) Is there a minikube start --kubernetes-version stable or minikube start --kubernetes-version latest that will auto-upgrade the cluster?

Perhaps we need a docs page to answer this.

@tstromberg
Copy link
Contributor

tstromberg commented Dec 19, 2019

minikube start --kubernetes-version=v1.17.0 will upgrade you, without re-downloading the VM image. That said, the base VM image is only ~120MB compared to the ~600MB it takes to download a new Kubernetes release.

We don't yet support 'stable' or 'latest' designators, but it would certainly be a great feature to add. If you or anyone else is interested in making this work, add a check for paramVersion == "stable" here:

if paramVersion == "" { // if the user did not specify any version then ...

As far as docs, I agree. I'd be happy to review any PR that adds it. Here is where I would probably put it: https://github.com/kubernetes/minikube/tree/master/site/content/en/docs/Tasks

@tstromberg
Copy link
Contributor

Also worth noting, this is the message users should see if there is an upgrade available:

out.T(out.ThumbsUp, "Kubernetes {{.new}} is now available. If you would like to upgrade, specify: --kubernetes-version={{.new}}

That doesn't invalidate the issues you've raised, just showing the guidance we are currently providing, as the documentation should match it.

@tstromberg tstromberg added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Dec 19, 2019
@tstromberg tstromberg changed the title How to upgrade cluster? Document upgrading a cluster Dec 19, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 18, 2020
prasadkatti added a commit to prasadkatti/minikube that referenced this issue Apr 3, 2020
Stop-gap solution for kubernetes#6122 until we have a separate page which discusses how to upgrade a minikube cluster.
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 17, 2020
@sharifelgamal
Copy link
Collaborator

We've added the documentation for this, I'm going to go ahead and close this. Feel free to reopen if necessary.

@life5ign
Copy link

Where is this in the docs? I can't find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

6 participants