Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Signing Process for Windows Installer #4841

Open
blueelvis opened this issue Jul 22, 2019 · 9 comments
Open

Add Signing Process for Windows Installer #4841

blueelvis opened this issue Jul 22, 2019 · 9 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. packaging/windows Windows packaging issues priority/backlog Higher priority than priority/awaiting-more-evidence. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/security Categorizes an issue or PR as relevant to SIG Security.

Comments

@blueelvis
Copy link
Contributor

As of now, whenever the minikube installer is run, the following screen comes up which makes it look as if the executable is malicious to a user -

image

This also revolves around having infrastructure/process to sign the executables/installers so that they can be verified.

Not sure if we need to have for other operating systems as well.

-Pranav

@afbjorklund
Copy link
Collaborator

afbjorklund commented Jul 23, 2019

Not sure if we need to have for other operating systems as well.

We do, as there are similar boxes coming up for the .deb and .rpm

#3110 deb/apt

#4716 rpm/yum

We could also sign the regular checksums, just plain old ascii/sigs ?

gpg --verify minikube-linux-amd64.sha256.sig

openssl sha256 minikube-linux-amd64 | awk '{print $2}'

@afbjorklund afbjorklund added packaging/windows Windows packaging issues kind/feature Categorizes issue or PR as related to a new feature. labels Jul 23, 2019
@blueelvis
Copy link
Contributor Author

Self signed cert can add the details so that the Publisher is displayed but it still will pop up this screen as the certificate won't be into the trusted root of the operating system. We need to get a known and valid certificate from a CA which is known.

Not sure what the process is to get a certificate from a CA over here.

@tstromberg tstromberg added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Aug 8, 2019
@tstromberg
Copy link
Contributor

@blueelvis - Not sure. Try asking #sig-release on Slack.

@tstromberg tstromberg added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Sep 23, 2019
@priyawadhwa
Copy link

Related to #5792 -- we're waiting on an official signing protocol from sig-release.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 16, 2020
@tstromberg tstromberg added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 6, 2020
@priyawadhwa priyawadhwa added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jul 29, 2020
@blueelvis
Copy link
Contributor Author

/remove-lifecycle stale

@sharifelgamal
Copy link
Collaborator

Yeah, we want to still do this.

@sftim
Copy link

sftim commented Feb 13, 2023

/sig security

@k8s-ci-robot k8s-ci-robot added the sig/security Categorizes an issue or PR as relevant to SIG Security. label Feb 13, 2023
@MiCurry
Copy link

MiCurry commented Jul 16, 2024

Still occurring as of this issue. I'm also not seeing any signatures on the executable.

minikube

If it is any help, I can offer some avenues for resolving this issue. I recently did a deep dive on Window's Defender SmartScreen and Certificates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. packaging/windows Windows packaging issues priority/backlog Higher priority than priority/awaiting-more-evidence. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/security Categorizes an issue or PR as relevant to SIG Security.
Projects
None yet
Development

No branches or pull requests

9 participants