Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign minikube binaries for macOS #5792

Open
tstromberg opened this issue Oct 30, 2019 · 13 comments
Open

Sign minikube binaries for macOS #5792

tstromberg opened this issue Oct 30, 2019 · 13 comments
Labels
area/build-release help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. os/macos priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@tstromberg
Copy link
Contributor

This would make it play better with Catalina.

There are some issues here in that the sig-release folks keep a tight reign on the Kubernetes certificate.

@tstromberg tstromberg added kind/feature Categorizes issue or PR as related to a new feature. os/macos area/build-release priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Oct 30, 2019
@tstromberg tstromberg added this to the v1.7.0-candidate milestone Oct 30, 2019
@tstromberg tstromberg removed this from the v1.7.0-candidate milestone Dec 9, 2019
@tstromberg tstromberg added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 9, 2019
@priyawadhwa
Copy link

This issue is currently waiting on an official signing protocol from Kubernetes.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2020
@tstromberg tstromberg added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/release Categorizes an issue or PR as relevant to SIG Release. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 6, 2020
@tstromberg
Copy link
Contributor Author

@tstromberg
Copy link
Contributor Author

#sig-release issue: kubernetes/release#839

@medyagh medyagh added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Jul 29, 2020
@medyagh
Copy link
Member

medyagh commented Jul 29, 2020

we still like to do this ! if anyone can help , help wanted !

@priyawadhwa priyawadhwa removed the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Dec 28, 2020
@medyagh
Copy link
Member

medyagh commented Nov 17, 2021

@prezha I wonder if u would like to take on this issue to start the conversation and add signing for minikube binaries?

@prezha
Copy link
Contributor

prezha commented Nov 18, 2021

@medyagh an interesting one - i accept the challenge!
i'd propose to start with signing the binaries for macos, then see for other platforms as well ({rpm, deb}, {exe}) as they all seem to need different handling

@prezha prezha self-assigned this Nov 18, 2021
@afbjorklund
Copy link
Collaborator

I think we have already given up on the deb and rpm, the current apt and yum repositories are deprecated and the new ones are not taking new projects (SIGs)

So signing for Windows Store has higher priority

Arguably re-adding the snap to Ubuntu after that...

@prezha
Copy link
Contributor

prezha commented Dec 1, 2021

re: releases - repos, package managers & signing (#5792, #3110, #4716, kubernetes/release#839, etc.) - a brief update on this:

Package: minikube
Version: 1.24.0-0
Priority: optional
Section: base
Maintainer: Thomas Strömberg <t+minikube@stromberg.org>
Installed-Size: unknown
Recommends: virtualbox
Download-Size: 23.5 MB
APT-Manual-Installed: yes
APT-Sources: https://minikube.triplepoint.tech/apt stable/main amd64 Packages
Description: Minikube
 minikube is a tool that makes it easy to run Kubernetes locally.
 minikube runs a single-node Kubernetes cluster inside a VM on your
 laptop for users looking to try out Kubernetes or develop with it
 day-to-day.
Information for package minikube:
---------------------------------
Repository     : minikube
Name           : minikube
Version        : 1.24.0-0
Arch           : x86_64
Vendor         : 
Installed Size : 54.1 MiB
Installed      : No
Status         : not installed
Source package : minikube-1.24.0-0.src
Summary        : Run Kubernetes locally
Description    : 
    Minikube is a tool that makes it easy to run Kubernetes locally.
    Minikube runs a single-node Kubernetes cluster inside a VM on your
    laptop for users looking to try out Kubernetes or develop with it
    day-to-day.
  • or, eg:
echo "[minikube]
name=minikube
baseurl=https://minikube.triplepoint.tech/yum
enabled=1
gpgcheck=1
gpgkey=https://keys.openpgp.org/vks/v1/by-fingerprint/61BCC110C8DFD072E2326DC92591E036E40127C3" > /etc/yum.repos.d/minikube.repo
  • yum clean all && yum makecache && yum info minikube ...

i've tested it with opensuse tumbleweed, debian 11, centos 8, and it would be great if others would also be interested in testing these repos with their favourite apt/yum package manager and report back if it's working for them or not (something like "full os: result" [w/ error details if any] would be ok)
please note that i only tried to give guidance/examples of how to configure repos above, but your mileage may vary and should be adapted for your specific case
in case of any errors with the binaries themselves - please try with the github versions before reporting any issue

if it works (for most, at least) and would be useful, we might promote it to "production" and publish the gpg key (https://keys.openpgp.org/vks/v1/by-fingerprint/61BCC110C8DFD072E2326DC92591E036E40127C3) on our website as well

thanks!

minikube.public.txt

@medyagh
Copy link
Member

medyagh commented Jan 24, 2022

@prezha is there anything new on this?

@sharifelgamal sharifelgamal assigned klaases and unassigned prezha Jan 31, 2022
@sharifelgamal sharifelgamal added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Jan 31, 2022
@sharifelgamal sharifelgamal added this to the 1.26.0-candidate milestone Jan 31, 2022
@prezha
Copy link
Contributor

prezha commented Mar 18, 2022

@medyagh sorry for my late reply on this topic

i've explored it a bit more and the findings are collated in a doc open for comments:
https://docs.google.com/document/d/1mAGEaz_jSJkD5mesALPXi0SgEUEi2H1tuu7hbmXMIUw/edit?usp=sharing

TL;DR: signing minikube binaries for macOS and Windows requires funding ($99/year and a wide range of ~$80-$700+/year respectively), and for Linux distros, we currently have an operational YUM and APT repos.

we can discuss options at our next office hours meeting

@spowelljr spowelljr added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 4, 2022
@spowelljr spowelljr modified the milestones: 1.26.0, 1.27.0-candidate Jun 24, 2022
@septatrix
Copy link

TL;DR: [...] and for Linux distros, we currently have an operational YUM and APT repos.

Under what URL could I find those? The ones I found are unsigned

@prezha
Copy link
Contributor

prezha commented Aug 19, 2022

hey @septatrix, there wasn't a big interest in these linux repos, so they haven't been kept up to date, and also the cert expired in the meantime

i've now refreshed the cert and added & signed all the release (ie, without beta and alpha) versions from minikube v1.24.0 - v1.26.1 (current atm), so you can try

please follow the steps above for your linux distro/package manager and share if it's working for you now

this is what apt reports now:

# apt show minikube -a
Package: minikube
Version: 1.26.1-0
Priority: optional
Section: base
Maintainer: Thomas Strömberg <t+minikube@stromberg.org>
Installed-Size: unknown
Recommends: virtualbox
Download-Size: 26.8 MB
APT-Sources: https://minikube.triplepoint.tech/apt stable/main amd64 Packages
Description: Minikube
 minikube is a tool that makes it easy to run Kubernetes locally.
 minikube runs a single-node Kubernetes cluster inside a VM on your
 laptop for users looking to try out Kubernetes or develop with it
 day-to-day.

Package: minikube
Version: 1.26.0-0
Priority: optional
Section: base
Maintainer: Thomas Strömberg <t+minikube@stromberg.org>
Installed-Size: unknown
Recommends: virtualbox
Download-Size: 26.6 MB
APT-Sources: https://minikube.triplepoint.tech/apt stable/main amd64 Packages
Description: Minikube
 minikube is a tool that makes it easy to run Kubernetes locally.
 minikube runs a single-node Kubernetes cluster inside a VM on your
 laptop for users looking to try out Kubernetes or develop with it
 day-to-day.

Package: minikube
Version: 1.25.2-0
Priority: optional
Section: base
Maintainer: Thomas Strömberg <t+minikube@stromberg.org>
Installed-Size: unknown
Recommends: virtualbox
Download-Size: 24.4 MB
APT-Sources: https://minikube.triplepoint.tech/apt stable/main amd64 Packages
Description: Minikube
 minikube is a tool that makes it easy to run Kubernetes locally.
 minikube runs a single-node Kubernetes cluster inside a VM on your
 laptop for users looking to try out Kubernetes or develop with it
 day-to-day.

Package: minikube
Version: 1.25.1-0
Priority: optional
Section: base
Maintainer: Thomas Strömberg <t+minikube@stromberg.org>
Installed-Size: unknown
Recommends: virtualbox
Download-Size: 23.8 MB
APT-Sources: https://minikube.triplepoint.tech/apt stable/main amd64 Packages
Description: Minikube
 minikube is a tool that makes it easy to run Kubernetes locally.
 minikube runs a single-node Kubernetes cluster inside a VM on your
 laptop for users looking to try out Kubernetes or develop with it
 day-to-day.

Package: minikube
Version: 1.25.0-0
Priority: optional
Section: base
Maintainer: Thomas Strömberg <t+minikube@stromberg.org>
Installed-Size: unknown
Recommends: virtualbox
Download-Size: 23.8 MB
APT-Sources: https://minikube.triplepoint.tech/apt stable/main amd64 Packages
Description: Minikube
 minikube is a tool that makes it easy to run Kubernetes locally.
 minikube runs a single-node Kubernetes cluster inside a VM on your
 laptop for users looking to try out Kubernetes or develop with it
 day-to-day.

Package: minikube
Version: 1.24.0-0
Priority: optional
Section: base
Maintainer: Thomas Strömberg <t+minikube@stromberg.org>
Installed-Size: unknown
Recommends: virtualbox
Download-Size: 23.5 MB
APT-Sources: https://minikube.triplepoint.tech/apt stable/main amd64 Packages
Description: Minikube
 minikube is a tool that makes it easy to run Kubernetes locally.
 minikube runs a single-node Kubernetes cluster inside a VM on your
 laptop for users looking to try out Kubernetes or develop with it
 day-to-day.

@klaases klaases removed their assignment Oct 17, 2022
@spowelljr spowelljr modified the milestones: 1.27.0-previous, 1.29.0 Nov 28, 2022
@spowelljr spowelljr modified the milestones: 1.31.0, 1.32.0 Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-release help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. os/macos priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests