Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minikube cache does not work as expected #17636

Closed
BartJansseune opened this issue Nov 16, 2023 · 6 comments
Closed

minikube cache does not work as expected #17636

BartJansseune opened this issue Nov 16, 2023 · 6 comments
Labels
cmd/cache Issues with the "cache" command co/runtime/containerd kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@BartJansseune
Copy link

What Happened?

Context:
containerd runtime
hyperv driver

When you perform a minikube cache reload, images are always reloaded into minikube because the hash that minikube derives from the tar file does not correspond with the hash that is reported by containerd (ctr).

Here's an extract from the log:
Line 6: I1116 15:59:26.521389 32088 ssh_runner.go:195] Run: /bin/bash -c "sudo ctr -n=k8s.io images check | grep redis"
Line 29: I1116 15:59:28.089851 32088 ssh_runner.go:235] Completed: /bin/bash -c "sudo ctr -n=k8s.io images check | grep redis": (1.5679596s)
Line 33: I1116 15:59:28.090359 32088 cache_images.go:116] "redis" needs transfer: "redis" does not exist at hash "e10bd12f0b2d6a1ff41c9555ebb2c65056ae612bc074f5f46ebf36e5445346cd" in container runtime
Line 38: I1116 15:59:28.091406 32088 localpath.go:146] windows sanitize: C:\ProgramData\Minikube.minikube\cache\images\amd64\redis -> C:\ProgramData\Minikube.minikube\cache\images\amd64\redis
Line 39: I1116 15:59:28.092953 32088 cri.go:216] Removing image: redis
Line 65: I1116 15:59:30.473989 32088 ssh_runner.go:195] Run: sudo /usr/bin/crictl rmi redis
Line 68: I1116 15:59:30.651216 32088 cache_images.go:286] Loading image from: C:\ProgramData\Minikube.minikube\cache\images\amd64\redis
Line 69: I1116 15:59:30.657076 32088 ssh_runner.go:195] Run: stat -c "%s %y" /var/lib/minikube/images/redis
Line 73: I1116 15:59:31.592669 32088 ssh_runner.go:356] copy: skipping /var/lib/minikube/images/redis (exists)
Line 81: I1116 15:59:33.566320 32088 containerd.go:269] Loading image: /var/lib/minikube/images/redis
Line 82: I1116 15:59:33.572283 32088 ssh_runner.go:195] Run: sudo ctr -n=k8s.io images import /var/lib/minikube/images/redis
Line 83: I1116 15:59:35.325326 32088 ssh_runner.go:235] Completed: sudo ctr -n=k8s.io images import /var/lib/minikube/images/redis: (1.7530428s)
Line 84: I1116 15:59:35.325326 32088 cache_images.go:315] Transferred and loaded C:\ProgramData\Minikube.minikube\cache\images\amd64\redis from cache

When you have a lot of cached images, this extends the startup time significantly

Attach the log file

log.txt

Operating System

Windows

Driver

Hyper-V

@afbjorklund afbjorklund added the kind/bug Categorizes issue or PR as related to a bug. label Nov 19, 2023
@afbjorklund
Copy link
Collaborator

afbjorklund commented Nov 19, 2023

It is supposed to use the same hash as reported by crictl (similar to what kind is using)

@afbjorklund afbjorklund added co/runtime/containerd cmd/cache Issues with the "cache" command priority/backlog Higher priority than priority/awaiting-more-evidence. labels Nov 19, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 17, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 18, 2024
@BartJansseune
Copy link
Author

Issue can be closed, Solved in v1.32.1

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/cache Issues with the "cache" command co/runtime/containerd kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

4 participants