Masking env passwords in start does not work when password includes encoded characters

[dennyferra]

The pull request #17116 included changes to mask proxy passwords. However, the regex used in pkg/minikube/node/start.go (https://github.com/kubernetes/minikube/blob/master/pkg/minikube/node/start.go#L748) uses \w+. This will not match passwords with special characters (like @ = %40) that have been URL encoded, for example: http://user:fake%21password@someproxy.com:80

Example (proxy credentials faked):

😄  minikube v1.32.0 on Microsoft Windows 10 Enterprise 10.0.19045.3570 Build 19045.3570
✨  Automatically selected the hyperv driver
💿  Downloading VM boot image ...
    > minikube-v1.32.1-amd64.iso....:  65 B / 65 B [---------] 100.00% ? p/s 0s
    > minikube-v1.32.1-amd64.iso:  292.96 MiB / 292.96 MiB  100.00% 42.57 MiB p
👍  Starting control plane node minikube in cluster minikube
💾  Downloading Kubernetes v1.28.3 preload ...
    > preloaded-images-k8s-v18-v1...:  403.35 MiB / 403.35 MiB  100.00% 67.17 M
🔥  Creating hyperv VM (CPUs=4, Memory=8192MB, Disk=20000MB) ...
🌐  Found network options:
    ▪ HTTP_PROXY=http://fakeuser:fake%21pass@myproy.com:80
    ▪ HTTPS_PROXY=http://fakeuser:fake%21pass@myproy.com:80
🐳  Preparing Kubernetes v1.28.3 on Docker 24.0.7 ...
    ▪ env HTTP_PROXY=http://fakeuser:fake%21pass@myproxy.com:80
    ▪ env HTTPS_PROXY=http://fakeuser:fake%21pass@myproy.com:80
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔗  Configuring bridge CNI (Container Networking Interface) ...
🔎  Verifying Kubernetes components...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: storage-provisioner, default-storageclass
💡  kubectl not found. If you need it, try: 'minikube kubectl -- get pods -A'
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-ci-robot]

@dennyferra:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/remove-lifecycle stale
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alessandrocapanna]

I would really like to work on it and contribute to minikube.
/assign

[lekaf974]

Looks this issue can be closed, right ?