Incorrect Value for current profile.

[Shubham82]

What Happened?

The Value for the Current profile is showing wrong under the Active column when running the command minikube profile list.

Please find the observation below:

Created 2 minikube profile i.e minikube and minikube2

First minikube profile:

$ minikube start
😄  minikube v1.30.1 on Ubuntu 20.04
✨  Automatically selected the docker driver. Other choices: virtualbox, ssh, none
📌  Using Docker driver with root privileges
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
💾  Downloading Kubernetes v1.26.3 preload ...
    > preloaded-images-k8s-v18-v1...:  397.02 MiB / 397.02 MiB  100.00% 4.89 Mi
🔥  Creating docker container (CPUs=2, Memory=7900MB) ...
🐳  Preparing Kubernetes v1.26.3 on Docker 23.0.2 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔗  Configuring bridge CNI (Container Networking Interface) ...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🔎  Verifying Kubernetes components...
🌟  Enabled addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

$ kubectl config current-context
minikube

$ minikube profile list
|----------|-----------|---------|--------------|------|---------|---------|-------|--------|
| Profile  | VM Driver | Runtime |      IP      | Port | Version | Status  | Nodes | Active |
|----------|-----------|---------|--------------|------|---------|---------|-------|--------|
| minikube | docker    | docker  | 192.168.49.2 | 8443 | v1.26.3 | Running |     1 | *      |
|----------|-----------|---------|--------------|------|---------|---------|-------|--------|

Second minikube profile:

$ minikube start -p minikube2
😄  [minikube2] minikube v1.30.1 on Ubuntu 20.04
✨  Automatically selected the docker driver. Other choices: virtualbox, ssh
📌  Using Docker driver with root privileges
👍  Starting control plane node minikube2 in cluster minikube2
🚜  Pulling base image ...
🔥  Creating docker container (CPUs=2, Memory=7900MB) ...
🐳  Preparing Kubernetes v1.26.3 on Docker 23.0.2 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔗  Configuring bridge CNI (Container Networking Interface) ...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🔎  Verifying Kubernetes components...
🌟  Enabled addons: storage-provisioner, default-storageclass
🏄  Done! kubectl is now configured to use "minikube2" cluster and "default" namespace by default

$ kubectl config current-context
minikube2

$ minikube profile list
|-----------|-----------|---------|--------------|------|---------|---------|-------|--------|
|  Profile  | VM Driver | Runtime |      IP      | Port | Version | Status  | Nodes | Active |
|-----------|-----------|---------|--------------|------|---------|---------|-------|--------|
| minikube  | docker    | docker  | 192.168.49.2 | 8443 | v1.26.3 | Running |     1 | *      |
| minikube2 | docker    | docker  | 192.168.58.2 | 8443 | v1.26.3 | Running |     1 |        |
|-----------|-----------|---------|--------------|------|---------|---------|-------|--------|

As you see above the current profile is shown as minikube not minikube2 while the correct value for the current profile is minikube2 (see kubectl config command above).

Attach the log file

None.

Operating System

Ubuntu

Driver

Docker

[Shubham82]

/kind bug

[Shubham82]

Using Following minikube version:

$ minikube version
minikube version: v1.30.1
commit: 08896fd1dc362c097c925146c4a0d0dac715ace0

[Shubham82]

cc @kubernetes/minikube-maintainers
PTAL!

[medyagh]

here the Active means the active minikube profile, which means,
for example if you run "minikube stop" without a "-p" minikube will assume that profile, and has nothing to do with the active kube context ... Maybe one way to make this less confusing would be a new column for active kubecontext but that would be maybe too many columns !

[Shubham82]

here the Active means the active minikube profile, which means,
for example if you run "minikube stop" without a "-p" minikube will assume that profile, and has nothing to do with the active kube context

Thanks @medyagh for the above information.

Maybe one way to make this less confusing would be a new column for active kubecontext but that would be maybe too many columns !

I agree with your above point, IMO we can Update the Column name for Active, instead of active we can use some meaningful name so that it will be useful to the users also we mention this thing somewhere in the docs, so the readers know about each column.

[Shubham82]

I think We can also update the following comment:

// ClusterFlagValue returns the current cluster name based on flags

because here it is mentioned the current cluster name which means the current cluster is in use and causes confusion while understanding the code.

More Info:

ClusterFlagValue() function is used to get the profile name which is further used to get the value(*) for the Active column.

[Shubham82]

@medyagh
WDYT?

[Shubham82]

Hi, @medyagh
What do you think about the above workaround?

PTAL!

[Shubham82]

@medyagh, Could you please take a look?

[Shubham82]

cc @kubernetes/minikube-maintainers
anyone from the maintainers, could you please take a look?

[Shubham82]

@medyagh, PTAL!

[Shubham82]

cc @kubernetes/minikube-maintainers
Please take a look at this issue

[Shubham82]

@kubernetes/minikube-maintainers and @medyagh
could you please give your thoughts, so that this issue will resolved?
Any help would be appreciated.

[Skalador]

Hi folks,

here the Active means the active minikube profile, which means, for example if you run "minikube stop" without a "-p" minikube will assume that profile, and has nothing to do with the active kube context ... Maybe one way to make this less confusing would be a new column for active kubecontext but that would be maybe too many columns !

I was not aware about the fact that the minikube profile is different from the active kubecontext. That being said, I would like to highlight both information in the minikube profile list and I came up with this idea:

minikube profile list
|-----------|-----------|---------|--------------|------|---------|---------|-------|--------------------|
|  Profile  | VM Driver | Runtime |      IP      | Port | Version | Status  | Nodes | Active Kubecontext |
|-----------|-----------|---------|--------------|------|---------|---------|-------|--------------------|
| *minikube | docker    | docker  | 192.168.49.2 | 8443 | v1.28.4 | Running |     1 |                    |
| minikube2 | docker    | docker  | 192.168.58.2 | 8443 | v1.28.4 | Running |     1 | *                  |
|-----------|-----------|---------|--------------|------|---------|---------|-------|--------------------|

This would highlight the active profile in the Profile Column with * (this symbol can be changed, if needed). Additionally the active kubecontext could be seen in the last column.

The current implementation looks like this:

minikube profile list
|-----------|-----------|---------|--------------|------|---------|---------|-------|--------------------|
|  Profile  | VM Driver | Runtime |      IP      | Port | Version | Status  | Nodes | Active             |
|-----------|-----------|---------|--------------|------|---------|---------|-------|--------------------|
| minikube  | docker    | docker  | 192.168.49.2 | 8443 | v1.28.4 | Running |     1 |                    |
| minikube2 | docker    | docker  | 192.168.58.2 | 8443 | v1.28.4 | Running |     1 | *                  |
|-----------|-----------|---------|--------------|------|---------|---------|-------|--------------------|

I will open a PR following this comment. Please let me know, what you think about this idea @medyagh. If you are fine with it, I will update the test cases and the documentation.
PS: I am new to contributing to this project. I would love to finish this contribution on my own with some guidance if something would not work out as expected.