Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--no-kubernetes fails if "kubernetes-version" defined in config #12871

Closed
salavessa opened this issue Nov 5, 2021 · 6 comments · Fixed by #12942
Closed

--no-kubernetes fails if "kubernetes-version" defined in config #12871

salavessa opened this issue Nov 5, 2021 · 6 comments · Fixed by #12942
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@salavessa
Copy link

Running minikube start --no-kubernetes fails if "kubernetes-version" is defined in config (or passed vi command argument).

$ minikube version
minikube version: v1.24.0
commit: 76b94fb3c4e8ac5062daf70d60cf03ddcc0a741b

Steps to reproduce the issue:

  1. define kubernetes version in ~/.minikube/config/config.json, e.g.
{
  "kubernetes-version": "1.21.5"
}
  1. run minikube start --no-kubernetes
$ minikube start --no-kubernetes
* minikube v1.24.0 on Microsoft Windows [...]
* Kubernetes 1.22.3 is now available. If you would like to upgrade, specify: --kubernetes-version=v1.22.3
* Using the virtualbox driver based on existing profile
* Starting minikube without Kubernetes minikube in cluster minikube
* Updating the running virtualbox "minikube" VM ...
* Preparing Kubernetes v1.21.5 on Docker 20.10.8 ...

X Exiting due to K8S_INSTALL_FAILED: kubeadm images: version too old: 0.0.0
*
╭─────────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                             │
│    * If the above advice does not help, please let us know:                                 │
│      https://github.com/kubernetes/minikube/issues/new/choose                               │
│                                                                                             │
│    * Please run `minikube logs --file=logs.txt` and attach logs.txt to the GitHub issue.    │
│                                                                                             │
╰─────────────────────────────────────────────────────────────────────────────────────────────╯

More: it also fails as above if the version is defined in the command line (independently of config file contents): minikube start --no-kubernetes --kubernetes-version=1.22.3 and although this command doesn't make much sense in I would still expect the kubernetes version to simply be ignored.

Thanks!

@medyagh
Copy link
Member

medyagh commented Nov 5, 2021

Thanks for creating this issue. This new feature was only tested on a new cluster. This is a bug and will include a fix for it in the next release

@spowelljr spowelljr added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 8, 2021
@spowelljr spowelljr added this to the 1.25.0 milestone Nov 8, 2021
@medyagh
Copy link
Member

medyagh commented Nov 11, 2021

@klaases it should tell the user
if they wanna use this feature they should start a new cluster or delete their current one

@medyagh
Copy link
Member

medyagh commented Nov 12, 2021

/assign @klaases

@medyagh
Copy link
Member

medyagh commented Nov 12, 2021

/assign klaases

@k8s-ci-robot
Copy link
Contributor

@medyagh: GitHub didn't allow me to assign the following users: klaases.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign klaases

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@klaases
Copy link
Contributor

klaases commented Nov 12, 2021

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants