Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove go.mod dependency on k8s.io/kubernetes #11871

Open
medyagh opened this issue Jul 1, 2021 · 4 comments
Open

remove go.mod dependency on k8s.io/kubernetes #11871

medyagh opened this issue Jul 1, 2021 · 4 comments
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@medyagh
Copy link
Member

medyagh commented Jul 1, 2021

currently in our go.mod we are depending on

k8s.io/kubernetes v1.21.2

which is not a good idea to use the whole kubernetes project as a lib, we currently only use a few "Constants" and feature gate types (to validate if a feature gate is valid)

I would suggest we copy those constants from kubernetes source code to our own constants file in constants package maybe k8s_constants.go

we cna update once a while manually using make target, to copy/update those constants from k8s source code.

make update-constants

and then remove the dependency to k8s.io/kubernetes in our go mod

@medyagh medyagh added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jul 1, 2021
@mahalrs
Copy link
Contributor

mahalrs commented Jul 1, 2021

I will work on this.

/assign @mahalrs

@medyagh
Copy link
Member Author

medyagh commented Jul 2, 2021

cool its yours @mahalrs

@mahalrs
Copy link
Contributor

mahalrs commented Jul 9, 2021

@medyagh
Should we copy all constants or only the ones that we are using? Also, what are we going to do with feature gate types. Currently we are only using keys from InitFeatureGates map. So, we can copy the keys from the map and store them in a slice. Also should we put this slice in pkg/constants/k8s_constants.go or something like pkg/constants/k8s_features.go.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 7, 2021
@sharifelgamal sharifelgamal added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 3, 2021
@spowelljr spowelljr added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

6 participants