Skip to content

Commit

Permalink
Avoid warning about the suggested memory size
Browse files Browse the repository at this point in the history
The recommendation is to use (at least) 2048 MB *for the VM*,
which means that you will end up something like 1992 MB total.
We should not issue warnings when using the recommended size,
so lower the limit to 1900 MB (kubeadm will validate 1700 MB).

The reason it is broken is because it uses different values
for different drivers, if running a VM or on Bare Metal...
There is also no difference anymore between the "usable"
and the "recommended", so this will need revisiting later.
  • Loading branch information
afbjorklund committed Jan 20, 2021
1 parent ce655bc commit fc8ef79
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/minikube/cmd/start_flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ const (
waitTimeout = "wait-timeout"
nativeSSH = "native-ssh"
minUsableMem = 1800 // Kubernetes (kubeadm) will not start with less
minRecommendedMem = 2000 // Warn at no lower than existing configurations
minRecommendedMem = 1900 // Warn at no lower than existing configurations
minimumCPUS = 2
minimumDiskSize = 2000
autoUpdate = "auto-update-drivers"
Expand Down

0 comments on commit fc8ef79

Please sign in to comment.