Skip to content

Commit

Permalink
Merge pull request #11841 from sharifelgamal/ugly-err
Browse files Browse the repository at this point in the history
remove ugly error message from kicbase and ISO autobuild
  • Loading branch information
medyagh authored Jun 30, 2021
2 parents d8f8e3f + 06c1da3 commit c2f18d9
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 20 deletions.
15 changes: 5 additions & 10 deletions hack/jenkins/build_iso.sh
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,11 @@ make release-iso | tee iso-logs.txt
ec=$?
if [ $ec -gt 0 ]; then
if [ "$release" = false ]; then
err=$(tail -100 iso-logs.txt)
gh pr comment ${ghprbPullId} --body "Hi ${ghprbPullAuthorLoginMention}, building a new ISO failed, with the error below:
<details>
<pre>
${err}
</pre>
</details>
Full logs are at https://storage.cloud.google.com/minikube-builds/logs/${ghprbPullId}/${ghprbActualCommit:0:7}/iso_build.txt
gh pr comment ${ghprbPullId} --body "Hi ${ghprbPullAuthorLoginMention}, building a new ISO failed.
See the logs at:
```
https://storage.cloud.google.com/minikube-builds/logs/${ghprbPullId}/${ghprbActualCommit:0:7}/iso_build.txt
```
"
fi
exit $ec
Expand Down
15 changes: 5 additions & 10 deletions hack/jenkins/kicbase_auto_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -67,16 +67,11 @@ CIBUILD=yes make push-kic-base-image | tee kic-logs.txt
ec=$?
if [ $ec -gt 0 ]; then
if [ "$release" = false ]; then
err=$(tail -100 kic-logs.txt)
gh pr comment ${ghprbPullId} --body "Hi ${ghprbPullAuthorLoginMention}, building a new kicbase image failed, with the error below:
<details>
<pre>
${err}
</pre>
</details>
Full logs are at https://storage.cloud.google.com/minikube-builds/logs/${ghprbPullId}/${ghprbActualCommit:0:7}/kic_image_build.txt
gh pr comment ${ghprbPullId} --body "Hi ${ghprbPullAuthorLoginMention}, building a new kicbase image failed.
See the logs at:
```
https://storage.cloud.google.com/minikube-builds/logs/${ghprbPullId}/${ghprbActualCommit:0:7}/kic_image_build.txt
```
"
fi
exit $ec
Expand Down

0 comments on commit c2f18d9

Please sign in to comment.