Skip to content

Commit

Permalink
better functional and test name
Browse files Browse the repository at this point in the history
  • Loading branch information
sharifelgamal committed Jun 25, 2021
1 parent c6e64f8 commit c283c80
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/integration/functional_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ func TestFunctional(t *testing.T) {
t.Fatalf("Unable to run more tests (deadline exceeded)")
}
if tc.name == "StartWithProxy" && runCorpProxy {
tc.name = "StartWithCorpProxy"
tc.validator = validateStartWithCorpProxy
tc.name = "StartWithCustomCerts"
tc.validator = validateStartWithCustomCerts
}
t.Run(tc.name, func(t *testing.T) {
tc.validator(ctx, t, profile)
Expand Down Expand Up @@ -543,9 +543,9 @@ func validateStartWithProxy(ctx context.Context, t *testing.T, profile string) {
startMinikubeWithProxy(ctx, t, profile, "HTTP_PROXY", srv.Addr)
}

// validateStartWithCorpProxy makes sure minikube start respects the HTTPS_PROXY environment variable
// validateStartWithCustomCerts makes sure minikube start respects the HTTPS_PROXY environment variable
// only runs on Github Actions for amd64 linux
func validateStartWithCorpProxy(ctx context.Context, t *testing.T, profile string) {
func validateStartWithCustomCerts(ctx context.Context, t *testing.T, profile string) {
defer PostMortemLogs(t, profile)
err := startCorpProxy(ctx, t)
if err != nil {
Expand Down

0 comments on commit c283c80

Please sign in to comment.