Merge pull request #15037 from spowelljr/fixDashboardCmd

Fix `minikube dashboard` failing on macOS
kubernetes · Sep 30, 2022 · b672a15 · b672a15
2 parents d566828 + b25b13f
commit b672a15
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/cmd/minikube/cmd/dashboard.go b/cmd/minikube/cmd/dashboard.go
@@ -180,15 +180,17 @@ func kubectlProxy(kubectlVersion string, binaryURL string, contextName string, p
 func readByteWithTimeout(r io.ByteReader, timeout time.Duration) (byte, bool, error) {
 	bc := make(chan byte, 1)
 	ec := make(chan error, 1)
+	defer func() {
+		close(bc)
+		close(ec)
+	}()
 	go func() {
 		b, err := r.ReadByte()
 		if err != nil {
 			ec <- err
 		} else {
 			bc <- b
 		}
-		close(bc)
-		close(ec)
 	}()
 	select {
 	case b := <-bc: