Merge pull request #9852 from prezha/fix-update-scripts

fix GHReleases() to use rls tag name instead of rls name for rls version
kubernetes · Dec 4, 2020 · a6d56c6 · a6d56c6
2 parents 9c3c127 + bbd0529
commit a6d56c6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/hack/update/github.go b/hack/update/github.go
@@ -221,7 +221,7 @@ func GHReleases(ctx context.Context, owner, repo string) (stable, latest string,
 			return "", "", err
 		}
 		for _, rl := range rls {
-			ver := rl.GetName()
+			ver := rl.GetTagName()
 			if !semver.IsValid(ver) {
 				continue
 			}

diff --git a/hack/update/update.go b/hack/update/update.go
@@ -88,8 +88,7 @@ func (i *Item) apply(data interface{}) error {
 	if i.Content == nil {
 		return fmt.Errorf("unable to update content: nothing to update")
 	}
-	org := string(i.Content)
-	str := org
+	str := string(i.Content)
 	for src, dst := range i.Replace {
 		out, err := ParseTmpl(dst, data, "")
 		if err != nil {