added missing err check to scanner and new section logs integration test

kubernetes · Feb 19, 2021 · 66ecadc · 66ecadc
1 parent 9aba32f
commit 66ecadc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/pkg/minikube/logs/logs.go b/pkg/minikube/logs/logs.go
@@ -214,6 +214,9 @@ func outputLastStart() error {
 	for s.Scan() {
 		out.Step(style.Empty, s.Text())
 	}
+	if err := s.Err(); err != nil {
+		return fmt.Errorf("failed to read file %s: %v", fp, err)
+	}
 	return nil
 }
 

diff --git a/test/integration/functional_test.go b/test/integration/functional_test.go
@@ -768,7 +768,7 @@ func validateLogsCmd(ctx context.Context, t *testing.T, profile string) {
 	if err != nil {
 		t.Errorf("%s failed: %v", rr.Command(), err)
 	}
-	expectedWords := []string{"apiserver", "Linux", "kubelet"}
+	expectedWords := []string{"apiserver", "Linux", "kubelet", "Last Start"}
 	switch ContainerRuntime() {
 	case "docker":
 		expectedWords = append(expectedWords, "Docker")