Skip to content

Commit

Permalink
Merge pull request #10458 from afbjorklund/podman-stable
Browse files Browse the repository at this point in the history
Change podman priority to default on Linux
  • Loading branch information
medyagh authored Mar 2, 2021
2 parents 6ea2b32 + fb90e7e commit 4501e70
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 15 deletions.
17 changes: 9 additions & 8 deletions pkg/minikube/registry/drvs/podman/podman.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,19 @@ import (
"k8s.io/minikube/pkg/minikube/registry"
)

var docURL = "https://minikube.sigs.k8s.io/docs/drivers/podman/"

// minReqPodmanVer is required the minimum version of podman to be installed for podman driver.
var minReqPodmanVer = semver.Version{Major: 1, Minor: 7, Patch: 0}
var minReqPodmanVer = semver.Version{Major: 2, Minor: 1, Patch: 0}

func init() {
priority := registry.Experimental
priority := registry.Default
if runtime.GOOS != "linux" {
// requires external VM set up
priority = registry.Experimental
}
// Staged rollout for default:
// - Linux
// - Linux (sudo podman)
// - macOS (podman-remote)
// - Windows (podman-remote)

Expand Down Expand Up @@ -93,11 +99,6 @@ func configure(cc config.ClusterConfig, n config.Node) (interface{}, error) {
}

func status() registry.State {
docURL := "https://minikube.sigs.k8s.io/docs/drivers/podman/"
if runtime.GOARCH != "amd64" {
return registry.State{Error: fmt.Errorf("podman driver is not supported on %q systems yet", runtime.GOARCH), Installed: false, Healthy: false, Fix: "Try other drivers", Doc: docURL}
}

podman, err := exec.LookPath(oci.Podman)
if err != nil {
return registry.State{Error: err, Installed: false, Healthy: false, Fix: "Install Podman", Doc: docURL}
Expand Down
8 changes: 1 addition & 7 deletions site/content/en/docs/drivers/podman.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,17 @@ aliases:

## Overview

{{% pageinfo %}}
This driver is experimental and in active development. Help wanted!
{{% /pageinfo %}}

The podman driver is an alternative container runtime to the [Docker]({{< ref "/docs/drivers/docker.md" >}}) driver.

## Requirements

- Linux or macOS operating systems on amd64 architecture
- Linux operating system
- Install [podman](https://podman.io/getting-started/installation.html)

{{% readfile file="/docs/drivers/includes/podman_usage.inc" %}}

## Known Issues

- Podman driver is not supported on non-amd64 architectures such as arm yet. For non-amd64 archs please use [other drivers]({{< ref "/docs/drivers/_index.md" >}})
- Podman v2 driver is not supported yet.
- Podman requirements passwordless running of sudo. If you run into an error about sudo, do the following:

```shell
Expand Down

0 comments on commit 4501e70

Please sign in to comment.