Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apiextensions: add invalid validation schema regex test #78453

Merged
merged 2 commits into from
Jun 1, 2019
Merged

apiextensions: add invalid validation schema regex test #78453

merged 2 commits into from
Jun 1, 2019
+35 −1

Conversation

sttts
Copy link
Contributor

@sttts sttts commented May 28, 2019 •
edited
Loading

Prevents #65470, and is good for published OpenAPI schemas, not to publish invalid data.

CustomResourceDefinition with invalid regular expression in the pattern field of OpenAPI v3 validation schemas are not considere structural.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 28, 2019
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. release-note-none Denotes a PR that doesn't merit a release note. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 28, 2019
@liggitt
Copy link
Member

liggitt commented May 28, 2019

/kind cleanup
/priority important-soon
/lgtm

@sttts
Copy link
Contributor Author

sttts commented May 28, 2019

/hold

Will use this to add a validation check.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 28, 2019
This was referenced May 28, 2019
Closed
Closed
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 28, 2019
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2019
@sttts sttts added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2019
@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label May 28, 2019
@sttts sttts removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels May 28, 2019
@liggitt liggitt added this to the v1.15 milestone May 29, 2019
@sttts
Copy link
Contributor Author

sttts commented May 30, 2019

We probably need ratcheting here.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2019
@sttts sttts force-pushed the sttts-crd-invalid-regex-test branch from 13602cf to 5f65aff Compare May 30, 2019 14:06
@sttts sttts removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2019
@sttts
Copy link
Contributor Author

sttts commented May 30, 2019

@liggitt updated for structural schemas. Ptal.

@sttts sttts force-pushed the sttts-crd-invalid-regex-test branch from 5f65aff to 74101af Compare May 30, 2019 14:08
@liggitt
Copy link
Member

liggitt commented May 30, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2019
@liggitt
Copy link
Member

liggitt commented May 30, 2019

the validation test is no longer correct since the validation was limited to structural validation

@liggitt liggitt mentioned this pull request May 30, 2019
Closed
@sttts sttts force-pushed the sttts-crd-invalid-regex-test branch from 74101af to 0ab6db2 Compare May 30, 2019 16:14
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2019
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@sttts sttts added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label May 30, 2019
@sttts
Copy link
Contributor Author

sttts commented May 30, 2019

/retest

CI is down.

@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@sttts
Copy link
Contributor Author

sttts commented May 30, 2019

/retest

1 similar comment
@sttts
Copy link
Contributor Author

sttts commented May 30, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 15a01d5 into kubernetes:master Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enisoc enisoc Awaiting requested review from enisoc

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/custom-resources cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.15
Development

Successfully merging this pull request may close these issues.
4 participants
@sttts @liggitt @k8s-ci-robot @fejta-bot