Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use server-side printing in kubectl get -w #76161

Merged
merged 7 commits into from
Apr 8, 2019
Merged

use server-side printing in kubectl get -w #76161

merged 7 commits into from
Apr 8, 2019
+391 −106

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Apr 4, 2019 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
Requests and handles server-side print events for kubectl get -w

Which issue(s) this PR fixes:
Fixes #66538

Does this PR introduce a user-facing change?:

`kubectl get -w` now prints custom resource definitions with custom print columns

/sig cli
/cc @smarterclayton @seans3

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 4, 2019
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 4, 2019
@liggitt liggitt force-pushed the kubectl-watch-table branch 3 times, most recently from 324ccd0 to 2a56631 Compare April 4, 2019 20:53
@liggitt liggitt added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 5, 2019
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member Author

liggitt commented Apr 5, 2019

/retest

@liggitt liggitt changed the title WIP - use server-side printing in kubectl get -w use server-side printing in kubectl get -w Apr 5, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2019
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

smarterclayton
smarterclayton reviewed Apr 5, 2019
View reviewed changes
pkg/kubectl/cmd/get/get.go
if o.IsHumanReadablePrinter {
// printing always takes the internal version, but the watch event uses externals
if o.IsHumanReadablePrinter && objToPrint.GetObjectKind().GroupVersionKind().GroupKind() != tableGK {
// printing anything other than tables always takes the internal version, but the watch event uses externals
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminds me for v1 we'll need two versions of this, beta1 and v1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one in particular just checks group/kind, so it's version neutral... places where we check for *metav1beta1.Table will definitely need to add a switch

@smarterclayton
Copy link
Contributor

looks reasonable, didn't see anything objectionable so far

@smarterclayton
Copy link
Contributor

/assign @smarterclayton

@soltysh soltysh self-assigned this Apr 5, 2019
@smarterclayton
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit c082ace into kubernetes:master Apr 8, 2019
@juanvallejo juanvallejo mentioned this pull request Apr 8, 2019
Closed
12 tasks
@liggitt liggitt mentioned this pull request Apr 8, 2019
Closed
@k8s-ci-robot
Copy link
Contributor

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-kubemark-e2e-gce-big 53e55d3 link /test pull-kubernetes-kubemark-e2e-gce-big

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt liggitt deleted the kubectl-watch-table branch April 8, 2019 19:29
@soltysh soltysh mentioned this pull request Nov 27, 2019
Closed
@vatsalparekh vatsalparekh mentioned this pull request Jan 29, 2020
Closed
@ardaguclu ardaguclu mentioned this pull request Aug 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton smarterclayton left review comments

@seans3 seans3 Awaiting requested review from seans3

Assignees

@soltysh soltysh

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CRD additionalPrinterColumns does not work with kubectl get SOMETHING -w
5 participants
@liggitt @k8s-ci-robot @fejta-bot @smarterclayton @soltysh