Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed alpha kubeconfig command #74628

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Removed alpha kubeconfig command #74628

merged 1 commit into from
Feb 27, 2019

Conversation

hpandeycodeit
Copy link

@hpandeycodeit hpandeycodeit commented Feb 26, 2019 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This removes the alpha kubeconfig command as discussed in #1381

Which issue(s) this PR fixes:

Fixes # 1381

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 26, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @hpandeycodeit. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 26, 2019
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. release-note Denotes a PR that will be considered when it comes time to generate release notes. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 26, 2019
neolit123
neolit123 reviewed Feb 27, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this PR @hpandeycodeit !

/priority important-longterm

before running CI tests please call ./hack/update-bazel.sh and include the changes in the same single commit. (git push -f works for that).

also see my note about .gitignore.
thanks.

@kubernetes/sig-cluster-lifecycle-pr-reviews

.gitignore Outdated
@@ -130,3 +130,4 @@ zz_generated_*_test.go

# generated by verify-godeps.sh
vendordiff.patch
/.metadata/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shouldn't touch the .gitignore file as part of this PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reverted it.

@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 27, 2019
@liggitt liggitt removed their request for review February 27, 2019 04:17
@hpandeycodeit
Copy link
Author

@neolit123 Thanks! I have updated the commit with the ./hack/update-bazel.sh

neolit123
neolit123 approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update.
/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hpandeycodeit, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2019
yagonobre
yagonobre reviewed Feb 27, 2019
View reviewed changes
Copy link
Member

@yagonobre yagonobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hpandeycodeit
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2019
@yagonobre
Copy link
Member

@hpandeycodeit I found a minor typo on release note depricated -> deprecated
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2019
@hpandeycodeit
Copy link
Author

@yagonobre Thanks for pointing it out. I have updated the release note.

@yagonobre
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7053e43 into kubernetes:master Feb 27, 2019
@hpandeycodeit
Copy link
Author

Thank you @yagonobre @neolit123 !! :)

This was referenced Mar 6, 2019
Closed
Closed
@neolit123 neolit123 mentioned this pull request Mar 6, 2019
Merged
@neolit123
Copy link
Member

@hpandeycodeit
we had to revert this PR since some users complained about the removal of the command.
we are going to look at this command again in 1.15.

can you please change the release note to NONE

instead of:

"kubeadm alpha kubeconfig" command is deprecated.
"kubeadm init phase kubeconfig admin" can be used instead to create kubeconfig files

thanks!

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 6, 2019
@hpandeycodeit
Copy link
Author

@neolit123 done. So that means this will remain for a while or we are completely reverting it back?

@neolit123
Copy link
Member

thanks.
it will remain for a while and we need to decide what to do with it in the 1.15 cycle as it's under "alpha".

subramanian-neelakantan pushed a commit to subramanian-neelakantan/kubernetes that referenced this pull request Mar 7, 2019
@timothysc
Revert "Merge pull request kubernetes#74628 from hpandeycodeit/alpha_…
ef31616 
…kubeconf"

This reverts commit 7053e43, reversing
changes made to d58ff3b.
subramanian-neelakantan pushed a commit to subramanian-neelakantan/kubernetes that referenced this pull request Mar 7, 2019
@k8s-ci-robot
Merge pull request kubernetes#75056 from timothysc/configuser
9ad296a 
Revert "Merge pull request kubernetes#74628 from hpandeycodeit/alpha_kubeconf"
@hpandeycodeit hpandeycodeit mentioned this pull request May 9, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yagonobre yagonobre yagonobre left review comments

@neolit123 neolit123 neolit123 approved these changes

@liztio liztio Awaiting requested review from liztio

Assignees

@yagonobre yagonobre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hpandeycodeit @k8s-ci-robot @yagonobre @neolit123