Move e2e ingress test manifests for GCE to a subdirectory #72092

vllry · 2018-12-17T02:25:45Z

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
The GCE-specific ingress manifest resources were organized inconsistently compared to the nginx-specific ones (which live in a subdirectory). This PR moves the GCE static-ip-2 assets to a gce directory, and updates path references.

Which issue(s) this PR fixes:

Fixes #58640

Special notes for your reviewer:
This is my first kubernetes/kubernetes PR, so please let me know if I've made an obvious or beginner's mistake.

Does this PR introduce a user-facing change?:

NONE

Update vllry/kubernetes with upstream changes

…s#58640)

k8s-ci-robot · 2018-12-17T02:25:52Z

Hi @vllry. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vllry · 2018-12-17T02:27:29Z

/sig network

vllry · 2018-12-17T02:30:24Z

/assign @eparis

vllry · 2018-12-17T02:40:32Z

/priority backlog

jdumars · 2018-12-17T03:08:54Z

/ok-to-test

BenTheElder · 2018-12-17T03:47:24Z

/retest
TestTerminalPodEviction flakes strike again! :(

vllry · 2018-12-17T04:49:03Z

Tests were indeed a flake, just need lgtm + approval. 😁

oomichi · 2019-01-15T18:31:30Z

Manifests of static-ip-2 are used only for e2e tests of gce/gke. So

/lgtm

vllry · 2019-03-01T18:32:53Z

@thockin @oomichi @eparis This PR is pretty old + small, would appreciate a review (or if you could toss in a different reviewer)

oomichi

@vllry Thanks for rebasing, just one comment

oomichi · 2019-03-01T19:00:58Z

test/e2e/upgrades/ingress.go

@@ -95,10 +95,9 @@ func (t *IngressUpgradeTest) Setup(f *framework.Framework) {
 	// Allocate a static-ip for the Ingress, this IP is cleaned up via CleanupGCEIngressController
 	t.ipName = fmt.Sprintf("%s-static-ip", ns.Name)
 	t.ip = t.gceController.CreateStaticIP(t.ipName)
-


This seems unnecessary change here for readability.

oomichi · 2019-03-01T19:44:56Z

Thanks for updating,

/lgtm

vllry · 2019-03-01T21:31:47Z

Thanks, still need a /approve.

vllry · 2019-03-07T22:59:45Z

@oomichi @eparis

oomichi · 2019-03-08T00:09:05Z

I don't have power of approval.
@spiffxp Could you take a look at this?

dims · 2019-03-13T16:11:06Z

/assign @spiffxp @mikedanese
/milestone v1.14

spiffxp · 2019-03-13T16:22:31Z

/approve

k8s-ci-robot · 2019-03-13T16:23:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp, vllry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~test/OWNERS~~ [spiffxp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vllry added 2 commits December 15, 2018 11:50

Merge pull request #1 from kubernetes/master

ab00560

Update vllry/kubernetes with upstream changes

Moved GCE-specific ingress test yaml to a ./gce directory. (kubernete…

3d81b0b

…s#58640)

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 17, 2018

k8s-ci-robot requested review from erictune and thockin December 17, 2018 02:26

k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Dec 17, 2018

k8s-ci-robot assigned eparis Dec 17, 2018

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 17, 2018

k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 17, 2018

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 17, 2018

k8s-ci-robot assigned oomichi Jan 15, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2019

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2019

Merge branch 'master' into move-gce-test-manifests

3de7307

Fix mispelled variable in ingress.go after rebase

776ac93

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 1, 2019

oomichi reviewed Mar 1, 2019

View reviewed changes

Tiny whitespace tweak in ingress.go

579764e

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2019

k8s-ci-robot assigned mikedanese and spiffxp Mar 13, 2019

k8s-ci-robot added this to the v1.14 milestone Mar 13, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2019

k8s-ci-robot merged commit 118e33d into kubernetes:master Mar 13, 2019

vllry mentioned this pull request Mar 16, 2019

REQUEST: New membership for vllry kubernetes/org#614

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move e2e ingress test manifests for GCE to a subdirectory #72092

Move e2e ingress test manifests for GCE to a subdirectory #72092

vllry commented Dec 17, 2018 •

edited

Loading

k8s-ci-robot commented Dec 17, 2018

vllry commented Dec 17, 2018

vllry commented Dec 17, 2018

vllry commented Dec 17, 2018

jdumars commented Dec 17, 2018

BenTheElder commented Dec 17, 2018

vllry commented Dec 17, 2018

oomichi commented Jan 15, 2019

vllry commented Mar 1, 2019

oomichi left a comment

oomichi Mar 1, 2019

vllry Mar 1, 2019

oomichi commented Mar 1, 2019

vllry commented Mar 1, 2019

vllry commented Mar 7, 2019

oomichi commented Mar 8, 2019

dims commented Mar 13, 2019

spiffxp commented Mar 13, 2019

k8s-ci-robot commented Mar 13, 2019

Move e2e ingress test manifests for GCE to a subdirectory #72092

Move e2e ingress test manifests for GCE to a subdirectory #72092

Conversation

vllry commented Dec 17, 2018 • edited Loading

k8s-ci-robot commented Dec 17, 2018

vllry commented Dec 17, 2018

vllry commented Dec 17, 2018

vllry commented Dec 17, 2018

jdumars commented Dec 17, 2018

BenTheElder commented Dec 17, 2018

vllry commented Dec 17, 2018

oomichi commented Jan 15, 2019

vllry commented Mar 1, 2019

oomichi left a comment

Choose a reason for hiding this comment

oomichi Mar 1, 2019

Choose a reason for hiding this comment

vllry Mar 1, 2019

Choose a reason for hiding this comment

oomichi commented Mar 1, 2019

vllry commented Mar 1, 2019

vllry commented Mar 7, 2019

oomichi commented Mar 8, 2019

dims commented Mar 13, 2019

spiffxp commented Mar 13, 2019

k8s-ci-robot commented Mar 13, 2019

vllry commented Dec 17, 2018 •

edited

Loading