DNS record scale test #63820

chrisohaver · 2018-05-14T20:20:06Z

What this PR does / why we need it:

Adds e2e scalability test for querying DNS with a scaled up number of records. Specifically, it creates ~~30 services per node~~ 10000 services, then queries the cluster DNS and validates the response. This relates to a graduation criteria listed in kubernetes/community#1956.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
none

Special notes for your reviewer:

Release note:

NONE

rajansandeep · 2018-05-14T20:27:08Z

/ok-to-test

rajansandeep · 2018-05-14T20:29:05Z

/sig network

rajansandeep · 2018-05-14T20:29:20Z

/sig scalability

shyamjvs · 2018-05-16T16:38:43Z

test/e2e/scalability/dns.go

@@ -0,0 +1,91 @@
+/*


Could you instead place this test under test/e2e/network?

Sig-scalability is a horizontal effort - scale testing for vertical features should ideally belong to the relevant sig (which in this case seems to be sig-networking).

chrisohaver · 2018-05-16T20:07:00Z

@johnbelamaric

rajansandeep · 2018-05-16T21:41:25Z

/test pull-kubernetes-bazel-test
/test pull-kubernetes-kubemark-e2e-gce

chrisohaver · 2018-05-17T14:44:02Z

@bowei, FYI

chrisohaver · 2018-05-17T15:09:35Z

/test pull-kubernetes-integration

fturib · 2018-05-21T19:34:01Z

/assign @bowei

chrisohaver · 2018-05-24T19:14:59Z

This no longer creates 30 services per node - instead it creates the maximum number of services, regardless of cluster size.

chrisohaver · 2018-05-24T20:19:49Z

flake?
/test pull-kubernetes-e2e-gce

fturib · 2018-05-25T16:04:52Z

@shyamjvs , @dnardo , @bowei : gentle reminder here for review of this e2e test for DNS. Code slush will happen soon. Thanks for your collaboration.

shyamjvs · 2018-05-25T16:17:12Z

test/e2e/network/dns_scale_records.go

@@ -0,0 +1,84 @@
+/*
+Copyright 2016 The Kubernetes Authors.


shyamjvs · 2018-05-25T16:19:00Z

test/e2e/network/dns_scale_records.go

+			defer GinkgoRecover()
+			framework.ExpectNoError(testutils.CreateServiceWithRetries(f.ClientSet, f.Namespace.Name, services[i]))
+		}
+		workqueue.Parallelize(16, len(services), createService)


Could you maybe expose this hard-coded value of 16 as some global constant?

shyamjvs · 2018-05-25T16:19:23Z

test/e2e/network/dns_scale_records.go

+
+	// answers dns for service - creates the maximum number of services, and then check dns record for one
+	It("answers dns for service", func() {
+		services := generateDnsServicesInNamespace(f.Namespace.Name, 10000)


Same as other comment. Expose this value as global constant.

shyamjvs · 2018-05-25T16:20:31Z

test/e2e/network/dns_common.go

@@ -169,6 +180,10 @@ func (t *dnsTestCommon) deleteConfigMap() {
 }

 func (t *dnsTestCommon) createUtilPod() {


Can't you just get rid of this function or replace it's uses with createUtilPodLabel?

chrisohaver · 2018-05-30T17:47:36Z

/retest

MrHohn

Thanks! This looks good overall.
/approve

chrisohaver · 2018-05-30T19:07:26Z

Thanks @MrHohn! Can you tag for the current release milestone?

MrHohn · 2018-05-30T19:13:20Z

Can you tag for the current release milestone?

Sorry I don't have that privilege. But no worries I will grab someone for help.

MrHohn · 2018-05-30T22:00:47Z

/lgtm

k8s-ci-robot · 2018-05-30T22:00:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisohaver, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~test/e2e/network/OWNERS~~ [MrHohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

MrHohn · 2018-05-30T22:05:15Z

/kind feature
/priority important-soon

fejta-bot · 2018-05-31T01:50:18Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot · 2018-05-31T05:20:19Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot · 2018-05-31T08:50:18Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot · 2018-05-31T12:20:19Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

chrisohaver · 2018-05-31T14:00:04Z

FYI, pull-kubernetes-kubemark-e2e-gce-big failure is not related to this change. It is currently failing consistently/universally since 2018-05-30 13:30 EDT.

fturib · 2018-05-31T14:32:52Z

@caseydavenport, @dcbw : Can you add the needed label "status/approved-for-milestone" for this e2e test for DNS scale - it is located in sig-network area on advise of sig-scalability guys.
Thanks!

fejta-bot · 2018-05-31T16:53:18Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot · 2018-05-31T20:44:20Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

k8s-github-robot · 2018-05-31T22:21:18Z

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@MrHohn @bowei @chrisohaver

Pull Request Labels

sig/network sig/scalability: Pull Request will be escalated to these SIGs if needed.
priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
kind/feature: New functionality.

Help

k8s-ci-robot · 2018-05-31T22:54:51Z

@chrisohaver: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-kubemark-e2e-gce-big	`c66f932`	link	`/test pull-kubernetes-kubemark-e2e-gce-big`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-github-robot · 2018-05-31T23:20:09Z

Automatic merge from submit-queue (batch tested with PRs 63445, 63820). If you want to cherry-pick this change to another branch, please follow the instructions here.

k8s-ci-robot requested review from dnardo and shyamjvs May 14, 2018 20:20

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 14, 2018

k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label May 14, 2018

k8s-ci-robot added the sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. label May 14, 2018

shyamjvs reviewed May 16, 2018

View reviewed changes

chrisohaver force-pushed the dnsonscale branch from 87782ce to 291150d Compare May 16, 2018 19:01

chrisohaver mentioned this pull request May 18, 2018

Add jobs for CoreDNS scalability tests kubernetes/test-infra#8078

Closed

k8s-ci-robot assigned bowei May 21, 2018

fturib mentioned this pull request May 24, 2018

Enable CoreDNS as a DNS plugin for Kubernetes kubernetes/enhancements#427

Closed

chrisohaver mentioned this pull request May 24, 2018

add [Feature:PerformanceDNS] ci test for coredns and kube-dns kubernetes/test-infra#8127

Merged

shyamjvs reviewed May 25, 2018

View reviewed changes

test/e2e/network/dns_scale_records.go Outdated

@@ -0,0 +1,84 @@

/*

Copyright 2016 The Kubernetes Authors.

Copy link

Member

shyamjvs May 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2018

shyamjvs reviewed May 25, 2018

View reviewed changes

MrHohn approved these changes May 30, 2018

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2018

freehan added this to the v1.11 milestone May 30, 2018

k8s-github-robot added the milestone/incomplete-labels label May 30, 2018

k8s-ci-robot assigned MrHohn May 30, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2018

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 30, 2018

k8s-github-robot added milestone/needs-approval and removed milestone/incomplete-labels labels May 30, 2018

thockin added the status/approved-for-milestone label May 31, 2018

k8s-github-robot removed the milestone/needs-approval label May 31, 2018

k8s-github-robot merged commit 471b573 into kubernetes:master May 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DNS record scale test #63820

DNS record scale test #63820

chrisohaver commented May 14, 2018 •

edited

Loading

rajansandeep commented May 14, 2018

rajansandeep commented May 14, 2018

rajansandeep commented May 14, 2018

shyamjvs May 16, 2018

chrisohaver commented May 16, 2018

rajansandeep commented May 16, 2018

chrisohaver commented May 17, 2018

chrisohaver commented May 17, 2018

fturib commented May 21, 2018

chrisohaver commented May 24, 2018

chrisohaver commented May 24, 2018

fturib commented May 25, 2018

shyamjvs May 25, 2018

shyamjvs May 25, 2018

shyamjvs May 25, 2018

shyamjvs May 25, 2018

chrisohaver commented May 30, 2018

MrHohn left a comment

chrisohaver commented May 30, 2018

MrHohn commented May 30, 2018

MrHohn commented May 30, 2018

k8s-ci-robot commented May 30, 2018

MrHohn commented May 30, 2018

fejta-bot commented May 31, 2018

fejta-bot commented May 31, 2018

fejta-bot commented May 31, 2018

fejta-bot commented May 31, 2018

chrisohaver commented May 31, 2018

fturib commented May 31, 2018

fejta-bot commented May 31, 2018

fejta-bot commented May 31, 2018

k8s-github-robot commented May 31, 2018

k8s-ci-robot commented May 31, 2018

k8s-github-robot commented May 31, 2018

		@@ -169,6 +180,10 @@ func (t *dnsTestCommon) deleteConfigMap() {
		}

		func (t *dnsTestCommon) createUtilPod() {

DNS record scale test #63820

DNS record scale test #63820

Conversation

chrisohaver commented May 14, 2018 • edited Loading

rajansandeep commented May 14, 2018

rajansandeep commented May 14, 2018

rajansandeep commented May 14, 2018

shyamjvs May 16, 2018

Choose a reason for hiding this comment

chrisohaver commented May 16, 2018

rajansandeep commented May 16, 2018

chrisohaver commented May 17, 2018

chrisohaver commented May 17, 2018

fturib commented May 21, 2018

chrisohaver commented May 24, 2018

chrisohaver commented May 24, 2018

fturib commented May 25, 2018

shyamjvs May 25, 2018

Choose a reason for hiding this comment

shyamjvs May 25, 2018

Choose a reason for hiding this comment

shyamjvs May 25, 2018

Choose a reason for hiding this comment

shyamjvs May 25, 2018

Choose a reason for hiding this comment

chrisohaver commented May 30, 2018

MrHohn left a comment

Choose a reason for hiding this comment

chrisohaver commented May 30, 2018

MrHohn commented May 30, 2018

MrHohn commented May 30, 2018

k8s-ci-robot commented May 30, 2018

MrHohn commented May 30, 2018

fejta-bot commented May 31, 2018

fejta-bot commented May 31, 2018

fejta-bot commented May 31, 2018

fejta-bot commented May 31, 2018

chrisohaver commented May 31, 2018

fturib commented May 31, 2018

fejta-bot commented May 31, 2018

fejta-bot commented May 31, 2018

k8s-github-robot commented May 31, 2018

k8s-ci-robot commented May 31, 2018

k8s-github-robot commented May 31, 2018

chrisohaver commented May 14, 2018 •

edited

Loading