Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #60794: Add retrying to audit logging e2e tests #61134

Merged
merged 1 commit into from
Mar 15, 2018
Merged

Automated cherry pick of #60794: Add retrying to audit logging e2e tests #61134

merged 1 commit into from
Mar 15, 2018

Conversation

crassirostris
Copy link

@crassirostris crassirostris commented Mar 13, 2018 •
edited
Loading

Cherry pick of #60794 on release-1.9.

Fixes #60719, since audit logging behavior has changed in 1.10. Purely e2e change, so no release note

#60794: Add retrying to audit logging e2e tests

NONE

/cc @sttts @liggitt

Add retrying to audit logging e2e tests
4a35324 
Signed-off-by: Mik Vyatskov <vmik@google.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 13, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 13, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 13, 2018
@crassirostris crassirostris added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. area/audit and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 13, 2018
@crassirostris crassirostris requested review from sttts, liggitt and tallclair and removed request for mikedanese and ericchiang March 13, 2018 21:49
@crassirostris crassirostris added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 13, 2018
@crassirostris crassirostris added this to the v1.9 milestone Mar 13, 2018
@crassirostris crassirostris added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/auth Categorizes an issue or PR as relevant to SIG Auth. labels Mar 13, 2018
sttts
sttts reviewed Mar 14, 2018
View reviewed changes
test/e2e/auth/audit.go
expectAuditLines(f, expectedEvents)
// The default flush timeout is 30 seconds, therefore it should be enough to retry once
// to find all expected events. However, we're waiting for 5 minutes to avoid flakes.
pollingInterval := 30 * time.Second
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably commented on the master commit already: that's a pretty high interval. why?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It matches the current flush delay for the audit backend

@sttts
Copy link
Contributor

sttts commented Mar 14, 2018

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2018
@liggitt
Copy link
Member

liggitt commented Mar 14, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crassirostris, liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@crassirostris @jpbetz @liggitt @mbohlool @tallclair

Pull Request Labels
  • sig/auth: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@crassirostris
Copy link
Author

@mbohlool Please take a look, it's necessary to stop test flaking

@liggitt
Copy link
Member

liggitt commented Mar 14, 2018

@jpbetz is acting 1.9 branch manager this week

@crassirostris
Copy link
Author

Oh, thanks!

@mbohlool
Copy link
Contributor

@crassirostris test fix is approved.

@mbohlool mbohlool added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 14, 2018
@crassirostris
Copy link
Author

/retest

2 similar comments
@crassirostris
Copy link
Author

/retest

@liggitt
Copy link
Member

liggitt commented Mar 15, 2018

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@liggitt
Copy link
Member

liggitt commented Mar 15, 2018

flaked on #61230

@liggitt
Copy link
Member

liggitt commented Mar 15, 2018

/retest

@liggitt
Copy link
Member

liggitt commented Mar 15, 2018

adding retest-not-required per discussion in #sig-release - https://kubernetes.slack.com/archives/C2C40FMNF/p1521142075000034

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 51ce05a into kubernetes:release-1.9 Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

@liggitt liggitt Awaiting requested review from liggitt

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@jpbetz jpbetz

@liggitt liggitt

@mbohlool mbohlool

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/audit cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
9 participants
@crassirostris @liggitt @sttts @k8s-ci-robot @k8s-github-robot @mbohlool @fejta-bot @jpbetz @tallclair