Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a better networking doc #5089

Merged
merged 1 commit into from
Mar 9, 2015
Merged

Add a better networking doc #5089

merged 1 commit into from
Mar 9, 2015

Conversation

thockin
Copy link
Member

@thockin thockin commented Mar 5, 2015

This makes a new docs/cluster dir - we should move all detailed cluster-setup related docs here.

Hopefully this explains a bit better what is going on.

@erictune erictune self-assigned this Mar 5, 2015
Before discussing the Kubernetes approach to networking, it is worthwhile to
review the "normal" way that networking works with Docker. By default, Docker
uses host-private networking. It creates a virtual bridge, called `docker0` by
default, and allocates an [RFC1918](https://tools.ietf.org/html/rfc1918) range
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RFC1918 does not use the word "range" anywhere.

For precision, how about " ... allocates a subnet from one of the private address blocks defined in RFC1918".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do.

@erictune
Copy link
Member

erictune commented Mar 5, 2015

Not sure about the new directory. What else would go in there? How about just putting this at the bottom of the current docs/networking.md.


GCE itself does not know anything about these IPs, though, so it will not NAT
them for outbound internet traffic. To achieve that we us an iptables rule to
masquerade traffic that is bound for IPs outside teh GCE project network
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/teh/the

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn, fixed

@erictune
Copy link
Member

erictune commented Mar 5, 2015

I found this a really useful document. I understood K8s networking much better after reading it.

@davidopp
Copy link
Member

davidopp commented Mar 6, 2015

Taking a look now.

* the IP that a container sees itself as is the same IP that others see it as

What this means in practice is that you can not just take two computers
running Docker and expect kubernetes to work. You must ensure that the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize Kubernetes everywhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@thockin
Copy link
Member Author

thockin commented Mar 6, 2015

Regarding new dir - I briefly discussed with Brian. I could see all of the getting started guides moving here, all of the networking-related docs, etc. Anything that the cluster admins would want to read but app developers might not care about. I could be talked out of it if you care...

@thockin
Copy link
Member Author

thockin commented Mar 6, 2015

Many comments addressed

@davidopp
Copy link
Member

davidopp commented Mar 6, 2015

No need for an LGTM from me, I trust you addressed whichever of my comments you thought were reasonable. :)

@erictune
Copy link
Member

erictune commented Mar 6, 2015

If you are planning to do the work to move other things into the docs/cluster dir in the next PR, then fine. Otherwise, let's not have a dir with one thing in it.

@thockin
Copy link
Member Author

thockin commented Mar 7, 2015

OK, I gave up on the extra dir - we can deal with that later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants