Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed master.yaml for reboots #4362

Closed
wants to merge 1 commit into from
Closed

Conversation

chanezon
Copy link

Without the -, that step fails on reboot, and invalidates the whole flannel unit.
I experienced this on Azure and aws.

Without the -, that step fails on reboot, and invalidates the whole flannel unit
@roberthbailey
Copy link
Contributor

Thanks for the fix. Our lawyers say that we can't take even simple changes like this without a signed CLA on file. CONTRIB.md explains the process.

@roberthbailey roberthbailey added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2015
@chanezon
Copy link
Author

Thanks, I understand:-)
I'll look into that process stuff tomorrow.

@pires
Copy link
Contributor

pires commented Feb 12, 2015

Can you change all cloud-configs for master, and not just this one?

  • docs/getting-started-guides/aws/cloud-configs/master.yaml
  • docs/getting-started-guides/aws/cloudformation-template.json

@brendandburns
Copy link
Contributor

@chanezon are you in MS Open Tech? I believe we're already have a CLA from them.

@chanezon
Copy link
Author

@brendanburns I saw the CLA, and I'm not part of OpenTech. I'll ask our Lawyer today.
In the meantime, @jeffmendoza or @ahmetalpbalkan maybe one of you can create a similar PR (it's one character long) and submit it:-)

@pires
Copy link
Contributor

pires commented Feb 13, 2015

I'll take care of it.
On Feb 13, 2015 6:05 PM, "Patrick Chanezon" notifications@github.com
wrote:

@brendanburns https://github.com/brendanburns I saw the CLA, and I'm
not part of OpenTech. I'll ask our Lawyer today.
In the meantime, @jeffmendoza https://github.com/jeffmendoza or
@ahmetalpbalkan https://github.com/ahmetalpbalkan maybe one of you can
create a similar PR (it's one character long) and submit it:-)


Reply to this email directly or view it on GitHub
#4362 (comment)
.

pires added a commit to pires/kubernetes that referenced this pull request Feb 13, 2015
@pires pires mentioned this pull request Feb 13, 2015
@chanezon
Copy link
Author

Thank you @pires!

@pires
Copy link
Contributor

pires commented Feb 13, 2015

Thank you @chanezon. Nice catch.

bgrant0607 added a commit that referenced this pull request Feb 17, 2015
@nikhiljindal
Copy link
Contributor

Closing this since it seems that it no longer needs merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants