-
Notifications
You must be signed in to change notification settings - Fork 41.2k
hack: Add gofmt to update-codegen.sh for consistent code formatting #133614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
hack: Add gofmt to update-codegen.sh for consistent code formatting #133614
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 20 02:00:38 UTC 2025. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akintunero The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @akintunero! |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @akintunero. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
- Add gofmt -w -s calls after each code generation step - Ensures all generated Go code is properly formatted and simplified - Addresses issue where generated code wasn't consistently formatted - Follows the pattern already used in gen_types_swagger_doc function
007c867
to
74aad7c
Compare
I think we're still settling on the preferred approach in discussion on the issue |
Ok thanks for the update @BenTheElder |
/easycla |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR adds
gofmt -w -s
calls after each code generation step inhack/update-codegen.sh
to ensure consistent code formatting and simplification of generated Go code.Why we need it:
goimports
, it doesn't rungofmt
with the-s
flag to simplify codegofmt
ensures all generated code follows Go best practices consistentlyWhat it fixes:
gofmt -s
(removes unnecessary complexity)Which issue(s) this PR is related to:
Fixes #133609
Special notes for your reviewer:
gen_types_swagger_doc
functiongofmt
calls use-w -s
flags for consistent behaviorgofmt
step for consistencyDoes this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
N/A
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR is related to:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: