Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KEP-4639] Add ImageVolumeSource node e2e tests #126220

Merged
merged 1 commit into from
Jul 24, 2024
Merged

[KEP-4639] Add ImageVolumeSource node e2e tests #126220

merged 1 commit into from
Jul 24, 2024

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jul 19, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Adding an node e2e test suite for the ImageVolumeSource API.

Which issue(s) this PR fixes:

Refers to kubernetes/enhancements#4639

Special notes for your reviewer:

Requires #125663

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 19, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 19, 2024
@saschagrunert saschagrunert changed the title Add ImageVolumeSource node e2e tests WIP: Add ImageVolumeSource node e2e tests Jul 19, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 19, 2024
@k8s-ci-robot k8s-ci-robot added area/kubelet area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 19, 2024
@saschagrunert saschagrunert mentioned this pull request Jul 19, 2024
Open
9 tasks
@saschagrunert saschagrunert force-pushed the image-volumesource-e2e branch 4 times, most recently from 11125ac to 4e91ad6 Compare July 22, 2024 09:51
@saschagrunert saschagrunert mentioned this pull request Jul 22, 2024
Merged
gnufied
gnufied reviewed Jul 22, 2024
View reviewed changes
pkg/volume/image/image.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024
@kannon92
Copy link
Contributor

@saschagrunert If we need container runtime support, I think the best approach may be a dedicated job for this feature. It is a bit of a pain to set up but it seems to work better than the "whack-a-mole" of trying to filter out the thousands of test configs that may run this with containerd.

@saschagrunert
Copy link
Member Author

@saschagrunert If we need container runtime support, I think the best approach may be a dedicated job for this feature. It is a bit of a pain to set up but it seems to work better than the "whack-a-mole" of trying to filter out the thousands of test configs that may run this with containerd.

I can add a dedicated job in test-infra. The question is: Is that PR fine as-is or do I need to change anything?

@kannon92
Copy link
Contributor

@saschagrunert If we need container runtime support, I think the best approach may be a dedicated job for this feature. It is a bit of a pain to set up but it seems to work better than the "whack-a-mole" of trying to filter out the thousands of test configs that may run this with containerd.

I can add a dedicated job in test-infra. The question is: Is that PR fine as-is or do I need to change anything?

I don't love merging tests without being able to confirm if they work or not.

The code looks good to me but I like to see confirmation that the test is passing before merge.

@saschagrunert saschagrunert added this to the v1.31 milestone Jul 23, 2024
@saschagrunert
Copy link
Member Author

@saschagrunert If we need container runtime support, I think the best approach may be a dedicated job for this feature. It is a bit of a pain to set up but it seems to work better than the "whack-a-mole" of trying to filter out the thousands of test configs that may run this with containerd.

I can add a dedicated job in test-infra. The question is: Is that PR fine as-is or do I need to change anything?

I don't love merging tests without being able to confirm if they work or not.

The code looks good to me but I like to see confirmation that the test is passing before merge.

Good, so I'm going to add the suite before we continue here.

@kannon92
Copy link
Contributor

/hold

Let's confirm these tests work before merge as stated above.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2024
@saschagrunert
Copy link
Member Author

See kubernetes/test-infra#33071

@saschagrunert saschagrunert mentioned this pull request Jul 24, 2024
Merged
@saschagrunert
Copy link
Member Author

The test focus is still wrong, fixing that in kubernetes/test-infra#33088

At least the test setup works 🤞

@saschagrunert saschagrunert self-assigned this Jul 24, 2024
@saschagrunert
Add ImageVolumeSource e2e tests
bc45288 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

/test pull-kubernetes-node-crio-cgrpv2-imagevolume-e2e

@saschagrunert
Copy link
Member Author

@kannon92 test are green: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/126220/pull-kubernetes-node-crio-cgrpv2-imagevolume-e2e/1816080394953428992

@saschagrunert
Copy link
Member Author

/retest

@kannon92 kannon92 mentioned this pull request Jul 24, 2024
Closed
@kannon92
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: eb501a478f12a7baba43c6d87eaa8571602f34a7

@saschagrunert
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2024
saschagrunert added a commit to saschagrunert/test-infra that referenced this pull request Jul 24, 2024
@saschagrunert
Disable ImageVolume tests for `pull-kubernetes-node-e2e-containerd-al…
f428e3a 
…pha-features`

containerd does not seem to have support for image volumes yet, so we
can skip the tests in the alpha node e2e test suite.

Refers to kubernetes/kubernetes#126220

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert mentioned this pull request Jul 24, 2024
Merged
@k8s-ci-robot k8s-ci-robot merged commit ab470aa into kubernetes:master Jul 24, 2024
17 checks passed
@saschagrunert saschagrunert deleted the image-volumesource-e2e branch July 24, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@gnufied gnufied gnufied left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@kannon92 kannon92 Awaiting requested review from kannon92

Assignees

@saschagrunert saschagrunert

@kannon92 kannon92

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
[sig-release] Bug Triage
Archived in project
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
5 participants
@saschagrunert @k8s-ci-robot @dims @kannon92 @gnufied