[kubectl] terminal dimensions not exported with 'exec' command

[antoineco]

When using kubectl exec the terminal dimensions are always set to 80x24 instead of matching the client's layout.

Of course it is possible to insert "env COLUMNS=$COLUMNS LINES=$LINES" before every command, but this is not very usable.

[bgrant0607]

cc @kubernetes/kubectl

[rvrignaud]

+1 for this issue. This is really annoying.

[chris-codaio]

+1

+1

[tslater]

+1

[thuey]

+1

[piersy]

+1

[maclof]

I'd love to see this fixed soon. It seems that the terminal window size isn't monitored by kubectl and sent to kubelet to resize.

We should probably be doing something like docker does here: https://github.com/docker/docker/blob/master/api/client/utils.go#L99

I noticed back in may @ncdc was working on a commit for this here: ncdc/origin@13220db so perhaps we could work from this?

I'll see if I can work on a PR

[ncdc]

I'm still planning on working on it but it's lower priority than some other
things on my plate. If you want to pick it up, that would be fine. It just
needs to continue to be backwards compatible with older clients and servers
that don't have this feature.

On Monday, January 4, 2016, Marc Lough notifications@github.com wrote:

I'd love to see this fixed soon. It seems that the terminal window size
isn't monitored by kubectl and sent to kubelet to resize.

We should probably be doing something like docker does here:
https://github.com/docker/docker/blob/master/api/client/utils.go#L99

I noticed back in may @ncdc https://github.com/ncdc was working on a
commit for this here: ncdc/origin@13220db
ncdc/origin@13220db
so perhaps we could work from this?

I'll see if I can work on a PR

—
Reply to this email directly or view it on GitHub
#13585 (comment)
.

[maclof]

@ncdc regarding backwards compatibility, I assume this should be implemented as streamingProtocolV3? similarly to how it's already been done? https://github.com/kubernetes/kubernetes/blob/master/pkg/client/unversioned/remotecommand/v2.go