Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add imagePullSecrets for debug command #1567

Closed
warjiang opened this issue Feb 29, 2024 · 10 comments
Closed

add imagePullSecrets for debug command #1567

warjiang opened this issue Feb 29, 2024 · 10 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@warjiang
Copy link

What would you like to be added:
add imagePullSecrets for debug like

kubectl debug node/mynode -it --image=busybox --image-pull-secrets=myRegistryKeySecretName1 --image-pull-secrets=myRegistryKeySecretName2

Why is this needed:
in case of enterprise, private registry is the first choice, if execute kubectl debug node/mynode -it --image=${registry}/busybox it will report image pull error, so we need add imagePullSecrets options.

@warjiang warjiang added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 29, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 29, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ardaguclu
Copy link
Member

I think, this will be handled by this feature kubernetes/enhancements#4292.

@ardaguclu
Copy link
Member

and this is the duplicate of #1506

@warjiang
Copy link
Author

and this is the duplicate of #1506

yes! it's exactly what I wanted

@warjiang
Copy link
Author

I think, this will be handled by this feature kubernetes/enhancements#4292.

em, new to kubernetes community, and how, it's not a breaking change, maybe you can copy the copy or just cherry-pick the commit, anyway is ok for me 😃

@warjiang
Copy link
Author

warjiang commented Mar 1, 2024

I think, this will be handled by this feature kubernetes/enhancements#4292.

@ardaguclu hi~ I'm new to kubernetes community, what should I do to make this change into KEP4292, making comments in kubernetes/enhancements#4292 ? any suggestions or advices 😃

@ardaguclu
Copy link
Member

@warjiang thanks for your enthusiasm. You'll get this feature for free, when this PR kubernetes/kubernetes#120346 merges.

@ardaguclu
Copy link
Member

I'm closing this as it has already been marked as duplicate.
/close

@k8s-ci-robot
Copy link
Contributor

@ardaguclu: Closing this issue.

In response to this:

I'm closing this as it has already been marked as duplicate.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@warjiang
Copy link
Author

warjiang commented Mar 6, 2024

I'm closing this as it has already been marked as duplicate. /close

ok. i'll close this pr in main repo of kubernetes
kubernetes/kubernetes#123581

thanks for your reply as well 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants