-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add imagePullSecrets
for debug
command
#1567
Comments
This issue is currently awaiting triage. SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I think, this will be handled by this feature kubernetes/enhancements#4292. |
and this is the duplicate of #1506 |
yes! it's exactly what I wanted |
em, new to kubernetes community, and how, it's not a breaking change, maybe you can copy the copy or just cherry-pick the commit, anyway is ok for me 😃 |
@ardaguclu hi~ I'm new to kubernetes community, what should I do to make this change into KEP4292, making comments in kubernetes/enhancements#4292 ? any suggestions or advices 😃 |
@warjiang thanks for your enthusiasm. You'll get this feature for free, when this PR kubernetes/kubernetes#120346 merges. |
I'm closing this as it has already been marked as duplicate. |
@ardaguclu: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ok. i'll close this pr in main repo of kubernetes thanks for your reply as well 😄 |
What would you like to be added:
add
imagePullSecrets
for debug likeWhy is this needed:
in case of enterprise, private registry is the first choice, if execute
kubectl debug node/mynode -it --image=${registry}/busybox
it will report image pull error, so we need addimagePullSecrets
options.The text was updated successfully, but these errors were encountered: