Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kind version & Add support for multiple CRI in kinder #1660

Merged
merged 2 commits into from
Jul 11, 2019

Conversation

fabriziopandini
Copy link
Member

This PR:

  • upgrade kind library to the latest version (v0.4.0)
  • introduces in kind support for multiple CRI, currently with docker and containerd implemented, thus allowing to preserve a test signal with docker
  • changes kinder e2e workflows to continue to use docker
  • aligns action implementation in kinder to kind (no more task, join using config files instead of flags)
  • simplifies and improve consistent actions output

All the e2e workflows are passing locally after those changes.

Ps. I apologize for the size of the PR.
In case, I'm open to suggestion to break down the change in multiple PR.
ATM, in order to reduce a little bit the pain of reviewers, I grouped files in commits

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 10, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2019
@fabriziopandini
Copy link
Member Author

@neolit123 thanks for the feedback!
everything should be addressed now

@neolit123
Copy link
Member

/lgtm
thanks.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1861ce4 into kubernetes:master Jul 11, 2019
@fabriziopandini fabriziopandini deleted the support-multiple-cri branch July 30, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants