Skip to content

Set the kubelet --hostname-override flag conditionally at kubeadm init time #846

Closed
kubernetes/kubernetes
#64706
@luxas

Description

When kubernetes/kubernetes#63887 merges, we should set the kubelet's --hostname-override flag to what's passed to kubeadm via the --node-name flag conditionally if cfg.NodeName != nodeutil.GetHostname("") (if the flag differs from the default) at kubeadm init time, in cmd/kubeadm/app/phases/kubelet/flags.go.

This will automagically fix #584
xref related issue: #822
/assign @liztio
as you're assigned to #584. LMK if you don't have time to do this.

Metadata

Labels

area/UXarea/securitykind/bugCategorizes issue or PR as related to a bug.lifecycle/activeIndicates that an issue or PR is actively being worked on by a contributor.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions