Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add description about pod nanny #490

Merged

Conversation

andyxning
Copy link
Member

What this PR does / why we need it:
This PR will add description about the addon-resizer component.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #481

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 9, 2018
@k8s-ci-robot k8s-ci-robot requested a review from brancz July 9, 2018 07:24
@andyxning andyxning force-pushed the add_description_about_pod_nanny branch 2 times, most recently from 5f90960 to 33260e2 Compare July 9, 2018 07:33
@andyxning
Copy link
Member Author

andyxning commented Jul 9, 2018

Ping @trondhindenes Please take a look at this PR and see whether this description can alleviate your doubt.

README.md Outdated
@@ -113,7 +113,13 @@ kube-state-metrics exposes its own metrics under `--telemetry-host` and `--telem

### Resource recommendation

Resource usage changes with the size of the cluster. As a general rule, you should allocate
Resource usage for kube-state-metrics changes with the size, i.e., the node number, of the cluster.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's actually a problem that it doesn't exactly scale with the number of nodes, but rather with the total number of objects, which can vastly vary even at the same node count. I think we should mention that here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Will enhance this description later today. ~

@andyxning andyxning force-pushed the add_description_about_pod_nanny branch from 33260e2 to 46a00d8 Compare July 12, 2018 07:48
@andyxning
Copy link
Member Author

@brancz PTAL.

@brancz
Copy link
Member

brancz commented Jul 12, 2018

/lgtm

thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyxning, brancz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cb6d547 into kubernetes:master Jul 12, 2018
@andyxning andyxning deleted the add_description_about_pod_nanny branch July 12, 2018 09:05
@trondhindenes
Copy link

Sorry for not seeing this before - looks good, thanks so much for adding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document resource limit configuration
4 participants