-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add description about pod nanny #490
add description about pod nanny #490
Conversation
5f90960
to
33260e2
Compare
Ping @trondhindenes Please take a look at this PR and see whether this description can alleviate your doubt. |
README.md
Outdated
@@ -113,7 +113,13 @@ kube-state-metrics exposes its own metrics under `--telemetry-host` and `--telem | |||
|
|||
### Resource recommendation | |||
|
|||
Resource usage changes with the size of the cluster. As a general rule, you should allocate | |||
Resource usage for kube-state-metrics changes with the size, i.e., the node number, of the cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's actually a problem that it doesn't exactly scale with the number of nodes, but rather with the total number of objects, which can vastly vary even at the same node count. I think we should mention that here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Will enhance this description later today. ~
33260e2
to
46a00d8
Compare
@brancz PTAL. |
/lgtm thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyxning, brancz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sorry for not seeing this before - looks good, thanks so much for adding! |
What this PR does / why we need it:
This PR will add description about the
addon-resizer
component.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #481