-
Notifications
You must be signed in to change notification settings - Fork 2.1k
perf: Reduce allocations when creating metric families #2807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: fpetkovski <filip.petkovsky@gmail.com>
e6e38b5 to
acac519
Compare
|
/hold /lgtm Thanks for the contribution! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fpetkovski, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
The metric family generates a series by using a
strings.Builderto write data into, and then converts the string into a byte slice. This causes extra allocations which are not needed since we can directly write into a byte slice.Benchmarks in CI show an improvement: https://github.com/kubernetes/kube-state-metrics/actions/runs/19236033135?pr=2807.
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Has no effect.
Which issue(s) this PR fixes: (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged)Fixes #