-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add kube_persistentvolume_volume_mode metric #2370
feat: add kube_persistentvolume_volume_mode metric #2370
Conversation
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
Welcome @ricardoapl! |
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
/triage accepted |
/lgtm Thanks for your contribution! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrueg, ricardoapl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Add
volumeMode
of PersistentVolumes as a separate new metric of its ownHow does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Increases (by adding a new metric)
Which issue(s) this PR fixes:
Fixes #1966