Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rexagod as reviewer #1900

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Conversation

dgrisonnet
Copy link
Member

Thank you for all the efforts you've been putting into kube-state-metrics and welcome to the team! 🎉

/assign @mrueg @fpetkovski
/cc @logicalhan @rexagod

Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
@k8s-ci-robot
Copy link
Contributor

@dgrisonnet: GitHub didn't allow me to request PR reviews from the following users: rexagod.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Thank you for all the efforts you've been putting into kube-state-metrics and welcome to the team! 🎉

/assign @mrueg @fpetkovski
/cc @logicalhan @rexagod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Nov 22, 2022
@dgrisonnet
Copy link
Member Author

dgrisonnet commented Nov 22, 2022

Looks like we should wait for kubernetes/org#3830 before merging

@fpetkovski
Copy link
Contributor

Thank you for all of your contributions 🎉

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 22, 2022
@rexagod
Copy link
Member

rexagod commented Nov 22, 2022

It's an honor to get to be a part of the team! Thank you Damien, Filip, Manuel, and Han for maintaining such a welcoming air around this project, making it easy for folks like me to contribute! I'll try my best to live up to this role! 🎉

@mrueg
Copy link
Member

mrueg commented Nov 22, 2022

/lgtm

Thanks for your contributions @rexagod! Looking forward to improving kube-state-metrics together with you :)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, fpetkovski, mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dgrisonnet,fpetkovski,mrueg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrueg
Copy link
Member

mrueg commented Nov 22, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2022
@rexagod
Copy link
Member

rexagod commented Nov 23, 2022

/verify-owners
kubernetes/org#3849 was merged.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Nov 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 898345f into kubernetes:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants