-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed as not planned
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.
Description
What would you like to be added:
A presubmit to validate stable metrics don't change metric name, add labels or delete labels.
Similar to k8s stable metrics presubmit.
Why is this needed:
Guarantee stable metrics are stable.
Due to lack of presubmit check, some stable metrics are changed. For example,
- stable metric
kube_persistentvolume_info
is changed in feat: Add local storage labels to kube_persistentvolume_info #1814 - stable metric
kube_service_status_load_balancer_ingress
is changed in Add default label of uid for service #1687
Describe the solution you'd like
- Import k8s metrics stability framework Import k8s metrics stability framework #1844 and Migrate all NewFamilyGenerator to NewFamilyGeneratorWithStability #1976
- Presubmit check Check stable metrics aren't changed #1836
Additional context
Metadata
Metadata
Assignees
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.