Skip to content

Presubmit checks for stable metrics #1833

@CatherineF-dev

Description

@CatherineF-dev

What would you like to be added:
A presubmit to validate stable metrics don't change metric name, add labels or delete labels.

Similar to k8s stable metrics presubmit.

Why is this needed:
Guarantee stable metrics are stable.

Due to lack of presubmit check, some stable metrics are changed. For example,

Describe the solution you'd like

  1. Import k8s metrics stability framework Import k8s metrics stability framework #1844 and Migrate all NewFamilyGenerator to NewFamilyGeneratorWithStability #1976
  2. Presubmit check Check stable metrics aren't changed #1836

Additional context

Metadata

Metadata

Labels

kind/featureCategorizes issue or PR as related to a new feature.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions