Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick up etcd version changes for a rolling update on master nodes #4371

Merged
merged 1 commit into from
Feb 12, 2018
Merged

Pick up etcd version changes for a rolling update on master nodes #4371

merged 1 commit into from
Feb 12, 2018

Conversation

KashifSaadat
Copy link
Contributor

Identified a couple issues when attempting to perform a rolling-update with a new ETCD version for an existing Kubernetes Cluster, so:

  • Add etcdClusterSpec Image & Version in bootstrap data for Master nodes
  • Reuse execWithTee fn for ETCD Command (tee & mkfifo in different path for newer image versions)

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 2, 2018
@KashifSaadat
Copy link
Contributor Author

/assign @gambol99 @justinsb

@KashifSaadat KashifSaadat mentioned this pull request Feb 2, 2018
Closed
@KashifSaadat
Copy link
Contributor Author

Needs a nice little test, hopefully I've not regressed anything! :D

@KashifSaadat KashifSaadat force-pushed the bootstrapscript-etcdClusterSpec branch 2 times, most recently from 0f19c5d to 38bb6be Compare February 5, 2018 09:52
@KashifSaadat
Copy link
Contributor Author

Fixed the failing tests.

@KashifSaadat KashifSaadat force-pushed the bootstrapscript-etcdClusterSpec branch from 38bb6be to 516a3f1 Compare February 6, 2018 13:25
This was referenced Feb 6, 2018
Closed
Closed
@KashifSaadat
Copy link
Contributor Author

/assign @chrislovecnm

@gambol99
Copy link
Contributor

gambol99 commented Feb 9, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2018
@gambol99
Copy link
Contributor

gambol99 commented Feb 9, 2018

/retest

@gambol99
Copy link
Contributor

gambol99 commented Feb 9, 2018

/hold
can you check the tests please @KashifSaadat

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2018
@KashifSaadat
Copy link
Contributor Author

Flaky tests I think, other PRs also failing.

/test pull-kops-e2e-kubernetes-aws

@KashifSaadat
- Add etcdClusterSpec Image & Version in bootstrap data for Master nodes
ac25853 
- Reuse execWithTee fn for ETCD Command (tee & mkfifo in different path for newer image versions)
@k8s-github-robot
Copy link

/lgtm cancel //PR changed after LGTM, removing LGTM. @KashifSaadat @chrislovecnm @gambol99 @justinsb

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2018
@KashifSaadat
Copy link
Contributor Author

/unhold

Tests fixed finally, ready for another review :)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2018
@gambol99
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gambol99, KashifSaadat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:
  • OWNERS [KashifSaadat,gambol99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8629f60 into kubernetes:master Feb 12, 2018
@krogon krogon mentioned this pull request Feb 20, 2018
Closed
@KashifSaadat KashifSaadat deleted the bootstrapscript-etcdClusterSpec branch April 11, 2018 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

@chrislovecnm chrislovecnm

@gambol99 gambol99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KashifSaadat @gambol99 @k8s-github-robot @k8s-ci-robot @justinsb @chrislovecnm