Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh autocompletion and updating docs #2406

Merged
merged 1 commit into from
Apr 22, 2017

Conversation

chrislovecnm
Copy link
Contributor

@chrislovecnm chrislovecnm commented Apr 22, 2017

Fixes: #857

Need some help with a bash user looking at the bash instructions. Paging @kris-nova or @justinsb :) I can test, but I am using the crappy version of bash on OSX.


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 22, 2017
Copy link
Member

@justinsb justinsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@geojaz geojaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is 👍 for my zsh buddies :)
they will be very happy. bash lgtm

@chrislovecnm
Copy link
Contributor Author

Being the merge bot .... pushing the button

@chrislovecnm chrislovecnm merged commit a679fd3 into kubernetes:master Apr 22, 2017
@chrislovecnm chrislovecnm deleted the zsh-autocomplete branch December 30, 2017 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants