create cluster: take correct k8s version #1802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
justinsb
force-pushed
the
fix_k8s_version_recommendation
branch
from
ad91eb1 to
737c9f4
Compare
We were not overriding the cluster version, even when a kubernetes version could be determined from the direct specifications.
justinsb
force-pushed
the
fix_k8s_version_recommendation
branch
from
737c9f4 to
5a4ddb2
Compare
krisnova
approved these changes
Feb 7, 2017
Contributor
krisnova
left a comment
krisnova
left a comment
There was a problem hiding this comment.
LGTM - Getting these recs in!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not overriding the cluster version, even when a kubernetes
version could be determined from the direct specifications.
This change is