Skip to content

Conversation

jaden-young
Copy link
Contributor

Closes #971

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2018
@cdrage
Copy link
Member

cdrage commented Mar 29, 2018

Hey @jaden-young thanks for the PR! Once you have signed the CLA we will be able to merge this :)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 29, 2018
@jaden-young
Copy link
Contributor Author

I've signed the CLA.

@hangyan
Copy link
Contributor

hangyan commented Mar 30, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2018
@hangyan hangyan merged commit b141064 into kubernetes:master Mar 30, 2018
@hangyan
Copy link
Contributor

hangyan commented Mar 30, 2018

@jaden-young Thanks for you contribution!

@hangyan
Copy link
Contributor

hangyan commented Mar 30, 2018

@cdrage Seems there are some errors after merge this PR, i'm looking on it.

@jaden-young
Copy link
Contributor Author

That's interesting, my apologies for not testing. Are/were there files living somewhere with the target names?

@hangyan
Copy link
Contributor

hangyan commented Mar 30, 2018

@jaden-young It's weird, the CI test for PR is OK. still looking on it.

@hangyan
Copy link
Contributor

hangyan commented Mar 30, 2018

@cdrage Can you help restart the build or locate the error? Didn't find out why the build failed!

@jaden-young jaden-young deleted the patch-1 branch March 30, 2018 14:09
@cdrage
Copy link
Member

cdrage commented Apr 3, 2018

Looks like CI passes now 👍 Odd that it did that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants