Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hostpath volume #957

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Support hostpath volume #957

merged 1 commit into from
Mar 19, 2018

Conversation

hangyan
Copy link
Contributor

@hangyan hangyan commented Mar 11, 2018 •
edited
Loading

fix #876 #109

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2018
@hangyan hangyan force-pushed the support-hostpath-volume branch 2 times, most recently from e168f81 to 8af2a01 Compare March 11, 2018 06:49
@hangyan hangyan force-pushed the support-hostpath-volume branch from 8af2a01 to cf833c8 Compare March 16, 2018 02:40
@cdrage
Copy link
Member

cdrage commented Mar 19, 2018

This code LGTM! Thanks @hangyan 👍

@cdrage cdrage merged commit 442caa4 into kubernetes:master Mar 19, 2018
@cdrage cdrage mentioned this pull request Mar 19, 2018
Closed
@hangyan hangyan deleted the support-hostpath-volume branch March 31, 2018 04:05
@willseward willseward mentioned this pull request Dec 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error transforming Kubernetes objects
3 participants
@hangyan @cdrage @k8s-ci-robot