Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting compose labels to k8s annotations #84

Merged
merged 1 commit into from
Aug 4, 2016
Merged

Converting compose labels to k8s annotations #84

merged 1 commit into from
Aug 4, 2016

Conversation

janetkuo
Copy link
Member

@janetkuo janetkuo commented Aug 4, 2016

Fixes #81

@ngtuna ngtuna added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2016
sebgoa
sebgoa reviewed Aug 4, 2016
View reviewed changes
examples/docker-voting.yml
@@ -18,6 +20,8 @@ services:

db:
image: postgres:9.4
labels:
- "com.example.description=Postres Database"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny typo there: "Postgres"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@janetkuo janetkuo force-pushed the labels-to-annotations branch from c1a432d to b71b70e Compare August 4, 2016 16:57
@ngtuna ngtuna merged commit c4d62c9 into kubernetes:master Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janetkuo @sebgoa @ngtuna