Warning on missing port information and no service created #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now when user will not provide any port information a warning will be shown and also service will not be created. Fixes kubernetes#58
ngtuna
added
the
lgtm
|
Merging since got lgtm! :) |
|
ok it's cool it's work as expected (not generating node port service)... but why make because generaly is normal to do not expose port because the container is only used by other container and are not exposed externaly... for example a database used by web backend... but may be usefull in place of not generating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when user will not provide any port information a warning will be shown and also service will not be created.
Fixes #58