Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated conversion doc #553

Merged
merged 1 commit into from
Apr 26, 2017
Merged

Updated conversion doc #553

merged 1 commit into from
Apr 26, 2017

Conversation

surajnarwade
Copy link
Contributor

docs/conversion.md is updated as tmpfs is supported now.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 11, 2017
kadel
kadel requested changes Apr 11, 2017
View reviewed changes
docs/conversion.md Outdated
@@ -13,7 +13,7 @@ This document outlines all the conversion details regarding `docker-compose.yaml
| depends_on | | N | | |
| dns | | N | | |
| dns_search | | N | | |
| tmpfs | | N | | |
| tmpfs | | Y | | Creates `emptyDir` volume & mounts inside container |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description is only partially true.
This descriptions makes it look like its regular emptyDir volume.
That is not true. Its emptDir with medium: Memory, it actually mounts given dir as tmpfs inside container.

@surajnarwade
Copy link
Contributor Author

cc @kadel

@kadel
Copy link
Member

kadel commented Apr 13, 2017

I don't see any changes in the message.
Can you also add reference to emptyDir to "K8s / OpenShift" column? It should say that its emptyDir with medium:Memory and link to https://kubernetes.io/docs/concepts/storage/volumes/#emptydir

@surajnarwade
Copy link
Contributor Author

@kadel . updated

cdrage
cdrage requested changes Apr 24, 2017
View reviewed changes
docs/conversion.md Outdated
@@ -15,7 +15,7 @@ This document outlines all the conversion details regarding `docker-compose.yaml
| depends_on | | N | | |
| dns | | N | | |
| dns_search | | N | | |
| tmpfs | | N | | |
| tmpfs | | Y | [Tmpfs](https://kubernetes.io/docs/concepts/storage/volumes/#emptydir) | Creates `emptyDir` volume with `medium:Memory` & mounts given directory inside container |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be: Pod.Spec.Containers.Volumes.EmptyDir for description instead Tmpfs.

@surajnarwade
Copy link
Contributor Author

@cdrage done

cdrage
cdrage requested changes Apr 26, 2017
View reviewed changes
docs/conversion.md Outdated
@@ -15,7 +15,7 @@ This document outlines all the conversion details regarding `docker-compose.yaml
| depends_on | | N | | |
| dns | | N | | |
| dns_search | | N | | |
| tmpfs | | N | | |
| tmpfs | | Y | [Pod.Spec.Containers.Volumes.EmptyDir](https://kubernetes.io/docs/concepts/storage/volumes/#emptydir) | Creates `emptyDir` volume with `medium:Memory` & mounts given directory inside container |
Copy link
Member

@cdrage cdrage Apr 26, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still nitpicking this, but could be better:
Creates emptyDir volume with medium set to memory Just medium:Memory is a tad confusing..

@surajnarwade
Updated conversion doc
9f849fb 
Solves kubernetes#548

`docs/conversion.md` is updated as `tmpfs` is supported now.
@cdrage
Copy link
Member

cdrage commented Apr 26, 2017

LGTM! Merging'

@cdrage cdrage merged commit 05a4089 into kubernetes:master Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrage cdrage cdrage requested changes

@kadel kadel kadel approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@surajnarwade @kadel @cdrage @k8s-ci-robot