-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified user-guide on kompose.io #480
Conversation
I have stupid question 😊 Do we even need this list here? Is this duplicating what is already in conversion.md I think we can just link to that document. It will be easier to keep it in one place |
I agree with @kadel :) |
@cdrage @kadel , I thought of updating list on kompose.io |
Yes, what @kadel is saying is removing it from both docs/user-guide.md in master as well as in gh-pages. |
yes, and replacing it with link to conversion table |
got it :) |
7b29207
to
ba31030
Compare
docs/user-guide.md
Outdated
``` | ||
"build", "cgroup_parent", "devices", "depends_on", "dns", "dns_search", "domainname", "env_file", "extends", "external_links", "extra_hosts", "hostname", "ipc", "logging", "mac_address", "mem_limit", "memswap_limit", "network_mode", "networks", "pid", "security_opt", "shm_size", "stop_signal", "volume_driver", "uts", "read_only", "stdin_open", "tty", "user", "ulimits", "dockerfile", "net" | ||
``` | ||
Currently `kompose` does not support some of the Docker Compose options, which are listed on [conversion](http://kompose.io/conversion/) page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some Docker Compose options
listed on the conversion document
Oh, and update the commit message as well please! |
ba31030
to
522f98a
Compare
@cdrage , updated both |
@surajnarwade Thanks, the git commit message still isn't modified however. |
modified user-guide as it will point to conversion document for unsupported docker-compose options
522f98a
to
04b9bab
Compare
@cdrage , my bad, updated now :) |
LGTM! 👍 |
Fixes #479