Add support for host:port:port #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
cdrage
force-pushed
the
host-container-protocol-bug
branch
3 times, most recently
from
576e2b3 to
750ce20
Compare
|
1 test doesn't pass, going to fix that :) |
cdrage
force-pushed
the
host-container-protocol-bug
branch
2 times, most recently
from
4a4cdd7 to
06c848d
Compare
|
Can this be covered by unit tests? otherwise LGTM |
|
@cdrage LGTM |
|
@procrypt Sure why not! :) |
cdrage
force-pushed
the
host-container-protocol-bug
branch
from
06c848d to
6bcc49d
Compare
|
Rebased ^^ |
|
@cdrage fix in tests and docs with all the supported ports type will help! code LGTM 👍 |
cdrage
force-pushed
the
host-container-protocol-bug
branch
2 times, most recently
from
30b2532 to
89548ea
Compare
|
All green 🎉 |
|
I meant if you can add go unit tests, instead of shell test to this pr 👼 I think is is better to cover as much as we can using proper go tests |
|
@kadel Np, I'll update that :) |
This adds support for supplying for example: "127.0.0.1:80:80/tcp" to docker-compose.yaml and converting it to it's corresponding Kubernetes / OpenShift hostIP. This commit also refactors the loadPorts function of compose.go Closes kubernetes#335
cdrage
force-pushed
the
host-container-protocol-bug
branch
from
89548ea to
438088f
Compare
|
@kadel Your wish is granted! Unit tests added. |
|
Sweet 👍 thank you. "Coverage increased (+2.3%) to 51.987%" 🎉 🥇 |
kadel
approved these changes
Feb 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for supplying for example:
"127.0.0.1:80:80/tcp" to docker-compose.yaml and converting it to it's
corresponding Kubernetes / OpenShift hostIP.
This commit also refactors the loadPorts function of compose.go