change strategy to recreate if volumes present, fix #264 #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
@containscafeine are you still working on this? |
|
@surajssd yep |
concaf
force-pushed
the
deployment_strategy
branch
2 times, most recently
from
d1eb888 to
da9c6d7
Compare
concaf
changed the title
cdrage
approved these changes
Feb 13, 2017
| case *deployapi.DeploymentConfig: | ||
| objType.Spec.Strategy.Type = deployapi.DeploymentStrategyTypeRecreate | ||
| } | ||
| } |
|
code LGTM, but wanna give it a try once by running it against application! |
|
@containscafeine also title says 'no test' change strategy to recreate if volumes present, no tests, fix #264 but you seem to have added tests? |
|
@containscafeine tested with etherpad application from fixtures and it works! would like to have this behavior documented then we are good to merge this. |
concaf
changed the title
concaf
force-pushed
the
deployment_strategy
branch
from
da9c6d7 to
120121f
Compare
|
@surajssd thanks for pointing that out, added docs. |
When volumes are specified in the Docker Compose files, then in case of Kubernetes, Deployment's Spec.Strategy.Type and in case of OpenShift, DeploymentConfig's Spec.Strategy.Type are set to "Recreate". This is a safer deployment strategy when Volumes are getting used. This commit also adds unit tests for Kubernetes as well as OpenShift, and fixes the failing functional tests (tests.sh) due to the change. No functional tests have been added since the functionality is already covered when the volume mounts are being tested earlier in the file. This fixes kubernetes#264
concaf
force-pushed
the
deployment_strategy
branch
from
120121f to
b73efa5
Compare
|
@surajssd good to go now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.